Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test PNG exports #918

Closed
alixander opened this issue Feb 27, 2023 · 2 comments · Fixed by #963
Closed

test PNG exports #918

alixander opened this issue Feb 27, 2023 · 2 comments · Fixed by #963
Assignees
@nhooyr

Comments

@alixander
Copy link
Collaborator

alixander commented Feb 27, 2023 •
edited
Loading

we'll need to test PNG exports, which means we'll need playwright to work on CI. is it doable on the Github provided runners or do we need to switch to our own then?

motivation:
recently had a regression with PNG exports: #911
@cyborg-ts cyborg-ts added this to D2 Feb 27, 2023
@nhooyr
Copy link
Contributor

nhooyr commented Feb 27, 2023

Should be fine on the github provided runners.

@nhooyr
Copy link
Contributor

nhooyr commented Feb 27, 2023 •
edited
Loading

Maybe as part of #903

nhooyr added a commit to nhooyr/d2 that referenced this issue Mar 3, 2023
@nhooyr
e2etests-cli: Add PNG test
7d2b765 
Closes terrastruct#903
Closes terrastruct#918
@nhooyr nhooyr mentioned this issue Mar 3, 2023
Merged
@nhooyr nhooyr closed this as completed in 9227021 Mar 3, 2023
@github-project-automation github-project-automation bot moved this to Done in D2 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhooyr nhooyr

Labels
None yet
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2etests-cli: Add PNG test nhooyr/d2
2 participants
@alixander @nhooyr