d2chaos: fixes chaos tests #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
approved these changes
Dec 6, 2022
nhooyr
reviewed
Dec 6, 2022
| // fixes \\ | ||
| id = strings.ReplaceAll(id, "\\", `\\`) | ||
| // replaces \n with \\n whenever \n is not preceded by \ (does not replace \\n) | ||
| re := regexp.MustCompile(`[^\\](\n)`) |
There was a problem hiding this comment.
My bad, for a moment I thought I had to replace the group and ended forgetting it there 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #376
Fixes the two issues in #376
Each commit should be a separate fix.
ifs there allowed iticon. I thought about adding some code to generate random URLs, but as we lived without it so far, I don't think this is critical, so skippeddagredagre_id_with_new_linetodagre_id_with_special_charsand added the new examples to that test