Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d2chaos: respect sequence diagrams #376

Closed
nhooyr opened this issue Dec 6, 2022 · 1 comment · Fixed by #394
Closed

d2chaos: respect sequence diagrams #376

nhooyr opened this issue Dec 6, 2022 · 1 comment · Fixed by #394
Assignees
Labels
bug Something isn't working

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Dec 6, 2022

https://github.com/terrastruct/d2/actions/runs/3627398645/jobs/6117297838

test: --- FAIL: TestD2Chaos (0.00s)
test:     d2chaos_test.go:49: writing generated files to out
test:     --- FAIL: TestD2Chaos/#00 (0.02s)
test:         d2chaos_test.go:82: failed to create "\"G\\n\x1c=f\x02>f)6\x17\x0ffk'np4\x18+W^-\x02>MC\x10\x1ew\" -> \"G\\n\x1c=f\x02>f)6\x17\x0ffk'np4\x18+W^-\x02>MC\x10\x1ew\".\"tk[TOmI(X\x05bv6K(6\x06 d@\"": failed to recompile:
test:             "G\n�=f�>f)6��fk'np4�+W^-�>MC��w": {
test:               shape: sequence_diagram
test:               "tk[TOmI(X�bv6K(6� d@": {shape: page}
test:             }
test:             "G\n�=f�>f)6��fk'np4�+W^-�>MC��w" -> "G\n�=f�>f)6��fk'np4�+W^-�>MC��w"."tk[TOmI(X�bv6K(6� d@"
test:             
test:             5:1: connections within sequence diagrams can connect only to other objects within the same sequence diagram

cc @gavin-ts @ejulio-ts

@nhooyr nhooyr added the bug Something isn't working label Dec 6, 2022
@cyborg-ts cyborg-ts added this to D2 Dec 6, 2022
nhooyr added a commit to nhooyr/d2 that referenced this issue Dec 6, 2022
@ejulio-ts ejulio-ts self-assigned this Dec 6, 2022
@ejulio-ts
Copy link
Contributor

ejulio-ts commented Dec 6, 2022

Another example (shape: image)

D2_CHAOS_MAXI=100 go test ./d2chaos -run $TestD2Chaos^                                                                              1 ↵  ✹ ✭gh-376-d2chaos 
--- FAIL: TestD2Chaos (0.00s)
    d2chaos_test.go:49: writing generated files to out
    --- FAIL: TestD2Chaos/#00 (0.01s)
        d2chaos_test.go:82: failed to set "\"\tFrX,f/G\x16\u007fD\r\".shape" to "\"image\"": failed to recompile:
            "Y0
               Z/oGgg+|N\ntekv": {
             pO	h4r5Ii07qtTrkpn: {shape: rectangle}
             pO	h4r5Ii07qtTrkpn ->pO	h4r5Ii07qtTrkpn
            }
            "Y0
               Z/oGgg+|N\ntekv" <-> "Y0
                                       Z/oGgg+|N\ntekv": '""'
            "Y0
               Z/oGgg+|N\ntekv" <- "Y0
                                      Z/oGgg+|N\ntekv"
            "Y0
               Z/oGgg+|N\ntekv" -> "Y0
                                      Z/oGgg+|N\ntekv"
            "Y0
               Z/oGgg+|N\ntekv" -> "Y0
                                      Z/oGgg+|N\ntekv"
            "Y0
               Z/oGgg+|N\ntekv" -> "Y0
                                      Z/oGgg+|N\ntekv"
            "Y0
               Z/oGgg+|N\ntekv" <- "Y0
                                      Z/oGgg+|N\ntekv"pO	h4r5Ii07qtTrkpn: '"68	~C|NaIz|>&:|h:jE0T.SfH�OL.<\$W&bmeZa?!?M7m0k#~<W5y2\nIIi=o^:ib0#Uhd)4c[Sw\nxF^4P%7t,[rdLT gY#gK;"'
            "Y0
               Z/oGgg+|N\ntekv" <-> "Y0
                                       Z/oGgg+|N\ntekv": '"\nC	NsCF6BlaIB4Riy,v
                                                                                JfO6h@>!9
                                                                                         bMZd?\$Fji0\$G>otsZC\$esS#"'
            "Y0
               Z/oGgg+|N\ntekv" -> "Y0
                                      Z/oGgg+|N\ntekv"
            "Y0
               Z/oGgg+|N\ntekv"pO	h4r5Ii07qtTrkpn -- "Y0
                                                              Z/oGgg+|N\ntekv"
            "Y0
               Z/oGgg+|N\ntekv"pO	h4r5Ii07qtTrkpn <- "Y0
                                                              Z/oGgg+|N\ntekv"
            t Mr\$LDo
                     O42l9d: {shape: sequence_diagram}
            "Y0
               Z/oGgg+|N\ntekv" -> t Mr\$LDo
Bbiy'' Ua)6,"'                              O42l9d: '"K
            t Mr\$LDo
                     O42l9d <- "Y0
                                  Z/oGgg+|N\ntekv"
": {shape: image}rX,f/GD
            
            18:18: image shape must include an "icon" field
            
FAIL
FAIL	oss.terrastruct.com/d2/d2chaos	0.233s
FAIL

ejulio-ts added a commit that referenced this issue Dec 6, 2022
@ejulio-ts ejulio-ts moved this to Done in D2 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants