Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch dagre to Goja #337

Merged
merged 1 commit into from
Dec 3, 2022
Merged

switch dagre to Goja #337

merged 1 commit into from
Dec 3, 2022

Conversation

alixander
Copy link
Collaborator

No description provided.

@alixander alixander marked this pull request as draft December 3, 2022 18:56
@alixander
Copy link
Collaborator Author

shit got weird. will keep investigating

Screen Shot 2022-12-03 at 10 56 23 AM

@alixander alixander mentioned this pull request Dec 3, 2022
Closed
@pleshevskiy
Copy link

shit got weird. will keep investigating

Screen Shot 2022-12-03 at 10 56 23 AM

But it's compact.) Are you going to keep the dagre or refuse it completely?

@alixander
Copy link
Collaborator Author

nah this render definitely isn't right

@alixander alixander marked this pull request as ready for review December 3, 2022 19:41
@alixander
Copy link
Collaborator Author

switched to a different version of dagre and it worked. sick.

@alixander alixander requested a review from nhooyr December 3, 2022 19:42
@alixander
Copy link
Collaborator Author

going to merge this first and then try to get elk and mathjax going

@alixander alixander merged commit b5dc40c into terrastruct:master Dec 3, 2022
@alixander alixander deleted the goja branch December 3, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr Awaiting requested review from nhooyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alixander @pleshevskiy