Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #96

Closed
alixander opened this issue Nov 15, 2022 · 14 comments
Closed

Windows support #96

alixander opened this issue Nov 15, 2022 · 14 comments

Comments

@alixander
Copy link
Collaborator

just dealing with CGO

@nhooyr nhooyr added this to D2 Nov 22, 2022
@alixander
Copy link
Collaborator Author

@nhooyr
Copy link
Contributor

nhooyr commented Nov 22, 2022

  • build host
  • terraauth update to support windows

In regards to the install script, idt it's worth adding a windows powershell/cmd.exe variant. Rather we add a https://chocolatey.org/ package instead.

@nhooyr
Copy link
Contributor

nhooyr commented Nov 22, 2022

Opened #154

@alixander
Copy link
Collaborator Author

just adding another: https://news.ycombinator.com/item?id=33713748

@nhooyr
Copy link
Contributor

nhooyr commented Nov 23, 2022

https://news.ycombinator.com/item?id=33714812

we could have install.sh working under git bash for sure I think

@nhooyr
Copy link
Contributor

nhooyr commented Dec 1, 2022

For tomorrow's release, I'll most likely just build windows releases manually.

@nhooyr nhooyr changed the title install.sh: Windows support Windows support Dec 2, 2022
@nhooyr
Copy link
Contributor

nhooyr commented Dec 2, 2022

Damn, sorry guys it looks like v8go doesn't even support windows anymore :(

https://github.com/rogchap/v8go#windows

I'm going to try and work around it but will need more time.

@nhooyr
Copy link
Contributor

nhooyr commented Dec 3, 2022

Also see #31.

I could try to compile v8 with emscripten to wasm and then run the JS with the wasm bundle under a go wasm runtime like https://github.com/wasmerio/wasmer-go (though it uses cgo it builds on windows). Or compiling the JS directly to wasm with something like https://github.com/Shopify/javy#build

And try out https://github.com/dop251/goja because with pure Go

As well as see if bundling the node binary is into our Go binary is feasible, then no cgo necessary.

@alixander
Copy link
Collaborator Author

@nhooyr i will give https://github.com/dop251/goja a try.

@alixander
Copy link
Collaborator Author

still working through some things but the fact it runs is promising. #337

@alixander
Copy link
Collaborator Author

alixander commented Dec 3, 2022

dagre is pretty small though. whether it can handle Mathjax's build is a bigger question

@alixander
Copy link
Collaborator Author

good fucking find. v8go has been replaced with Goja. should be all good for full windows build

@nhooyr
Copy link
Contributor

nhooyr commented Dec 6, 2022

Screenshot 2022-12-06 at 2 55 27 AM

@nhooyr
Copy link
Contributor

nhooyr commented Dec 6, 2022

See #378

@nhooyr nhooyr closed this as completed Dec 6, 2022
@nhooyr nhooyr moved this to Done in D2 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants