Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove workaround related to passthrough_behavior for older providers #24

Merged
merged 3 commits into from
Mar 6, 2021

Conversation

jamesla
Copy link
Contributor

@jamesla jamesla commented Mar 6, 2021

Description

Removing old workaround that is no longer needed.

Motivation and Context

The issue that this workaround resolves has been fixed in aws 3.3.0 and newer versions of terraform don't allow you to set lifecycle ignores for a property that isn't specified as far as I can tell.

The error is:

Error: expected passthrough_behavior to be one of [WHEN_NO_MATCH NEVER WHEN_NO_TEMPLATES], got

The issue is:
hashicorp/terraform-provider-aws#11148 (comment)

Breaking Changes

This update forces users to upgrade their version of the AWS provider from 2.59 to at least 3.3.0.

How Has This Been Tested?

I have tested this locally.

@jamesla jamesla changed the title chore: remove old workaround Remove old workaround that is now causing errors in newer versions of Terraform Mar 6, 2021
@antonbabenko antonbabenko changed the title Remove old workaround that is now causing errors in newer versions of Terraform fix: Remove workaround related to passthrough_behavior for older providers Mar 6, 2021
@antonbabenko antonbabenko merged commit 799dfd3 into terraform-aws-modules:master Mar 6, 2021
@antonbabenko
Copy link
Member

Thanks for the improvement. This is completely acceptable to ask users to upgrade AWS provider.

AWS provider 3.3.0 has been released more than half a year ago.

v0.11.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants