Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passthrough_behaviour complaining in newer versions of terraform #16

Closed
wants to merge 1 commit into from

Conversation

jamesla
Copy link
Contributor

@jamesla jamesla commented Mar 6, 2021

Bumps the api gateway to version 0.11.0 which resolves the error that can be triggered on newer versions of terraform:

Error: expected passthrough_behavior to be one of [WHEN_NO_MATCH NEVER WHEN_NO_TEMPLATES], got

Associated PR and fix here: terraform-aws-modules/terraform-aws-apigateway-v2#24

@ofhouse ofhouse changed the base branch from main to release-2.x March 7, 2021 11:42
@ofhouse ofhouse changed the base branch from release-2.x to main March 7, 2021 11:43
@ofhouse
Copy link
Member

ofhouse commented Mar 7, 2021

Thanks for the contribution, bumping the terraform-aws-apigateway-v2 version should be fine 👍

Unfortunately the current main branch already contains a lot of breaking changes for an upcoming release, so we cannot create a new 2.x.x release from it.

I created a new branch in the repo called release-2.x which contains the state from the last v2.0.0 release.

However the PR has to be rebased or recreated in order to land the change on the release-2.x branch, since the main branch you pushed already contains the breaking changes.

In your local repository you have to:

  • Checkout the release-2.x branch from this repository

    # Add the upstream remote if you not already have
    git remote add upstream git@github.com:dealmore/terraform-aws-next-js-image-optimization.git
    
    # Checkout the `release-2.x` branch from the upstream remote
    git fetch upstream
    git checkout upstream/release-2.x
    
    # Create a new local branch where you want to add your changes
    git checkout -b bump-api-gateway-v2
  • Change the version in main.tf and commit it

  • Push the changes to your repository

    git push --set-upstream origin bump-api-gateway-v2
  • Create a new PR from the pushed branch.

Sorry for the circumstances here, but since the main branch is our development branch it is a bit tricky to apply changes to an older version. 😄

@jamesla
Copy link
Contributor Author

jamesla commented Mar 7, 2021

Sure thing I've created a new PR for that release branch #18

I'm guessing this one has to stay open though so that the changes make it into the next version once this branch returns to a working state?

@ofhouse
Copy link
Member

ofhouse commented Mar 7, 2021

👍
Once #18 is landed in 2.0.1 I will merge the release-2.x branch back into main, which keeps the history of this change and prevents the release-2.x branch from being in a detached state.

So I am closing it for now.

@ofhouse ofhouse closed this Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants