fix: remove domain verification enforcement

[jvelasquezjs]

Description

Fixing #10 - Removed domain verification enforcement

Reason being: unnecessary and restrictive filtering in the SAN and domain_name, causing terraform to fail and augmenting complexity in the code.

[jvelasquezjs]

@antonbabenko, @reegnz , @mrferos, @ezelenka

Can you please confirm this would work in all the scenarios you are using this module in? If not, please feel free to debate / challenge here.

Thanks

[jvelasquezjs]

Test Apply outputs:

this_acm_certificate_arn = arn:aws:acm:eu-west-1:795797303247:certificate/f4932824-08f9-483a-a2f5-58154b2b7ff3
this_acm_certificate_domain_validation_options = [
  {
    "domain_name" = "*.my-domain-name.com"
    "resource_record_name" = "_c15f0e83dc12a06b1dc0e1c3bdcff0bb.my-domain-name.com."
    "resource_record_type" = "CNAME"
    "resource_record_value" = "_15221dcbc5a83ea943078665196caef9.duyqrilejt.acm-validations.aws."
  },
  {
    "domain_name" = "my-domain-name.com"
    "resource_record_name" = "_c15f0e83dc12a06b1dc0e1c3bdcff0bb.my-domain-name.com."
    "resource_record_type" = "CNAME"
    "resource_record_value" = "_15221dcbc5a83ea943078665196caef9.duyqrilejt.acm-validations.aws."
  },
]
this_acm_certificate_validation_emails = []
validation_route53_record_fqdns = [
  "_c15f0e83dc12a06b1dc0e1c3bdcff0bb.my-domain-name.com",
  "_c15f0e83dc12a06b1dc0e1c3bdcff0bb.my-domain-name.com",
]

[antonbabenko]

The code you are proposing to remove is used to create just unique DNS records. As you can see in your output there are duplicates in validation_route53_record_fqdns and in resource_record_name.

You can try to run examples/complete-dns-validation and see the result.

[antonbabenko]

@jvelasquezjs Please give a try to v2.3.0.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.