Used string manipulation instead of templating to remove characters from SAN

[mrferos]

Description

Hi, was experiencing the issue described here

I believe this change creates the list that was being done in the templating, my local testing shows that it no longer errors out but I have not tried the scenarios listed in the issue.

I left the original template bit in as I was just trying to get this working, but can remove it.

[reegnz]

I think this should be this instead:

distinct(
  split(":", replace(join(":", concat(var.domain_name, var.subject_alternative_names)), "*.", ""))

Because var.domain_name might also be a wildcard, so that needs to be included in the whole *. filtering.

[jvelasquezjs]

Hi @reegnz , @mrferos

CC: @ezelenka

Can I ask why are we using this distinct_domain_names validation / enforcement? Perhaps I am not able to see the big picture, but IIRC in version 1.4.0 (terraform 11) we used the SAN and domain_name this way?

terraform-aws-acm/main.tf

Line 25 in fa8e57d

resource "aws_route53_record" "validation" {

BTW: We are running into the same problem, where planning cannot compute the data source (issue #10)

Thanks!

[jvelasquezjs]

Please Review PR #16

[bryantbiggs]

hi @mrferos , @jvelasquezjs - is this still an issue on the latest version of the module or can we close?

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.