Update data server build step to run with ubuntu 20.04 and change platform tag #6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
149199b to
ad57d76
Compare
|
Downloading the created wheels from CI and auditing the wheel show that the ❯ unzip tensorboard-data-server.zip
Archive: tensorboard-data-server.zip
inflating: tensorboard_data_server-0.8.0a0-py3-none-any.whl
inflating: tensorboard_data_server-0.8.0a0-py3-none-macosx_10_9_x86_64.whl
inflating: tensorboard_data_server-0.8.0a0-py3-none-manylinux_2_31_x86_64.whl
❯ ls
tensorboard_data_server-0.8.0a0-py3-none-any.whl
tensorboard_data_server-0.8.0a0-py3-none-macosx_10_9_x86_64.whl
tensorboard_data_server-0.8.0a0-py3-none-manylinux_2_31_x86_64.whl
❯ pip install auditwheel
...
❯ auditwheel show tensorboard_data_server-0.8.0a0-py3-none-manylinux_2_31_x86_64.whl
tensorboard_data_server-0.8.0a0-py3-none-manylinux_2_31_x86_64.whl is
consistent with the following platform tag: "manylinux_2_31_x86_64".
The wheel references external versioned symbols in these
system-provided shared libraries: libdl.so.2 with versions
{'GLIBC_2.2.5'}, libm.so.6 with versions {'GLIBC_2.2.5'},
libpthread.so.0 with versions {'GLIBC_2.12', 'GLIBC_2.2.5'},
libgcc_s.so.1 with versions {'GCC_3.0', 'GCC_3.3', 'GCC_4.2.0'},
libc.so.6 with versions {'GLIBC_2.28', 'GLIBC_2.25', 'GLIBC_2.3.2',
'GLIBC_2.29', 'GLIBC_2.3.4', 'GLIBC_2.18', 'GLIBC_2.15', 'GLIBC_2.3',
'GLIBC_2.10', 'GLIBC_2.17', 'GLIBC_2.9', 'GLIBC_2.14', 'GLIBC_2.4',
'GLIBC_2.7', 'GLIBC_2.2.5'}
This constrains the platform tag to "manylinux_2_31_x86_64". In order
to achieve a more compatible tag, you would need to recompile a new
wheel from source on a system with earlier versions of these
libraries, such as a recent manylinux image. |
arcra
approved these changes
Oct 17, 2023
…tform tag This should ensure that the generated wheels are compatible with the `manylinux_2_31` platform tag, since that's the version of glibc shipped with ubuntu 20.04. This aligns us with https://peps.python.org/pep-0600/ instead of reconfiguring our CI workflow to build on a system with glibc<=2.17 to keep supporting the `manylinux2014` tag (https://peps.python.org/pep-0599/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ensure that the generated wheels are compatible with the
manylinux_2_31platform tag, since that's the version ofglibcshipped with ubuntu 20.04. This aligns us with https://peps.python.org/pep-0600/ instead of reconfiguring our CI workflow to build on a system withglibc<=2.17to keep supporting themanylinux2014tag (https://peps.python.org/pep-0599/).