Skip to content

Commit

Permalink
Update data server build step to run with ubuntu 20.04 and change pla…
Browse files Browse the repository at this point in the history
…tform tag

This should ensure that the generated wheels are compatible with the
`manylinux_2_31` platform tag, since that's the version of glibc shipped
with ubuntu 20.04. This aligns us with https://peps.python.org/pep-0600/
instead of reconfiguring our CI workflow to build on a system with
glibc<=2.17 to keep supporting the `manylinux2014` tag
(https://peps.python.org/pep-0599/)
  • Loading branch information
groszewn committed Oct 17, 2023
1 parent 9c25f00 commit 604e886
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,11 @@ jobs:
fail-fast: false
matrix:
mode: ['native']
platform: ['ubuntu-22.04', 'macos-12']
platform: ['ubuntu-20.04', 'macos-12']
rust_version: ['1.65.0']
include:
- mode: 'universal'
platform: 'ubuntu-22.04'
platform: 'ubuntu-20.04'
rust_version: '1.65.0'
steps:
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
Expand Down
5 changes: 3 additions & 2 deletions tensorboard/data/server/pip_package/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ def main():
if cpu_name == "arm64":
mac_platform = "macosx_11_0"
platform_name = {
# using platform tag values from TensorFlow releases
"Linux": "manylinux2014",
# We build on an Ubuntu 20.04 (Focal Fossa) image, which ships with
# glibc 2.31 (https://launchpad.net/ubuntu/focal/+source/glibc).
"Linux": "manylinux_2_31",
"Darwin": mac_platform,
}.get(platform.system())

Expand Down

0 comments on commit 604e886

Please sign in to comment.