Cleanup supported k8s version in test-runner #1507
Conversation
|
/assign @lbernick PTAL. Thanks! |
|
/test plumbing-unit-tests |
|
@chuangw6: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
So the dogfooding cluster (from google cloud) is still running 1.24 (so it's.. still supported by someone). Same goes from supported version fo kubernetes version in OpenShift. In addition, tektoncd/pipeline has min kubernetes version set to 1.24, so I would really want to be able to make sure it works on 1.24 from our CI — until we bump the min version to 1.25 or 1.26, or … /hold cc @afrittoli |
b30bd9a to
d4acfb5
Compare
Yes. I've pushed the newly built test-runner image to docker hub and test the image on the pipeline repo. Here is the output. Looks like it works well. |
@vdemeester Thanks for the input! SGTM. Do WE have a plan/timeline for updating k8s version in dogfooding cluster and also other tools you just mentioned? |
I think that until Tekton supports 1.24 or until we setup k8s matrix testing we need to keep dogfooding to 1.24. |
d4acfb5 to
56b3edd
Compare
Step 1 for tektoncd#1499 This commit - removes support for EOL k8s versions i.e. 1.20, 1.21, 1.22, 1.23. - updates support for k8s 1.24 to the latest patch - 1.24.15 - updates support for k8s 1.25 to the latest patch - 1.25.11 - adds support for latest k8s versions including 1.26 and 1.27. - updates MetalLB to v0.13.10 which doesn't deploy pod security policy which is not supported in k8s 1.25+. References: - https://github.com/kubernetes-sigs/kind/releases/tag/v0.20.0 - https://metallb.universe.tf/release-notes/#version-0-13-5 Signed-off-by: Chuang Wang <chuangw@google.com>
56b3edd to
d8cda42
Compare
|
I added back the support for k8s 1.24 - the latest patch 1.24.15, and I have tested on 1.24 with the newly built image and it works fine. So now the test runner image should support k8s 1.24, 1.25, 1.26 & 1.27. And in prow config (example), we can choose which k8s version we want to run on when using the test-runner image. Also this PR updates the installation of the load-balancer MetalLB. The previous version we installed needs to install PodSecurityPolicy which has been deprecated since k8s 1.25. Are we good to merge this PR now? |
| @@ -83,36 +83,25 @@ if [[ "${E2E_ENV}" != "" && ! -f "${E2E_ENV}" ]]; then | |||
| fi | |||
|
|
|||
| # The version map correlated with this version of KinD | |||
| KIND_VERSION="v0.11.1" | |||
There was a problem hiding this comment.
do we still need this env var?
There was a problem hiding this comment.
I don't think it's used anywhere. Instead, the arg with same name defined in dockerfile is actually used.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Changes
Step 1 for #1499
This commit
References:
Signed-off-by: Chuang Wang chuangw@google.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.