-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tekton task to run unit tests #949
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
tekton/ci-unit-test.yaml
Outdated
workingdir: /workspace/src/${inputs.params.package} | ||
command: | ||
- go | ||
args: ["test", "-v", "-cover", "./..."] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want that race condition flag too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and/or a flexible set of flags, maybe with a default?
(need that array type! :D #207)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point for race
!
yeah we really need #207 😅 as of now, we need a wrapper or some bashism to support flexible set of flags (which reduce a bit readability)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated (in a separate commit)
This adds a Task to run pipeline's unit tests Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
e903fd1
to
a88b1b0
Compare
It should be possible to use different flags with this task. The readability is a bit reduce because we are missing Array type of parameters. Once we have those type of parameter, we can simplify this. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
a88b1b0
to
33bdc7b
Compare
@bobcatfish removed the |
/test pull-tekton-pipeline-integration-tests |
/lgtm |
Changes
This adds a Task to run pipeline's unit tests
tektoncd/catalog
later on as it's meant to be a reusable task 👼Improvements possible:
Closes #532
cc @bobcatfish
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.