Initial golang tasks #43
Conversation
This adds initial golang tasks : build (`golang-build`), tests (`golang-tests`) and linting (`golangci-lint`, using golangci-lint). Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| targetPath: src/${inputs.params.package} | ||
| steps: | ||
| - name: lint | ||
| image: golangci/golangci-lint:${inputs.params.version} |
There was a problem hiding this comment.
Do you think there's any benefit in having the default include the :, which would allow users to request a version by digest (version: @sha256:...) or specify "" to get :latest (less useful)
There was a problem hiding this comment.
ah, very good point ! I think it make sense indeed 👼
There was a problem hiding this comment.
ping, still see version's default without the :
This'll also need an update to _default:_s in README.md
|
(I've removed |
|
/lgtm |
|
/test pull-tekton-catalog-integration-tests |
Changes
Related to tektoncd/pipeline#954 and tektoncd/pipeline#949, this provides initial Tasks for Golang.
This adds initial golang tasks : build (
golang-build), tests (golang-tests) and linting (golangci-lint, using golangci-lint).Improvements (todos):
OutputResources: either of typegitorstorage?Closes tektoncd/pipeline#532
Closes tektoncd/pipeline#558
/cc @chmouel @bobcatfish
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.