feat: introduce when expressions to steps #7746

ericzzzzzzz · 2024-03-11T17:49:32Z

Changes

This PR introduces the use of "when" expressions within Tekton steps, enabling conditional execution. The controller marshals the taskSpec.steps[*].when data and passes it to the entrypointer. The entrypointer evaluates these expressions to determine if a step should run. Skipped steps exit with code 0 and a 'Skipped' TerminationReason. This approach allows steps to use previous step results in their conditions, even though the controller still creates the container for skipped steps.

Note: StepAction doesn't own whenExpressions, whenExpressions should be defined under steps[*] to control the flow.

fixes: #7623

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
pre-commit Passed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

 introduce when expressions to steps.

/kind feat

tekton-robot · 2024-03-11T17:49:35Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tekton-robot · 2024-03-11T17:49:36Z

@ericzzzzzzz: The label(s) kind/feat cannot be applied, because the repository doesn't have them.

In response to this:

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps

Has Tests included if any functionality added or changed

pre-commit Passed

Follows the commit message standard

Meets the Tekton contributor standards (including functionality, content, code)

Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep

Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.

Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE
/kind feat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2024-03-11T17:58:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.1%	-0.5
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	89.0%	72.1%	-16.9

tekton-robot · 2024-03-11T17:59:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.1%	-0.5
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	89.0%	72.1%	-16.9

tekton-robot · 2024-03-11T18:01:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.1%	-0.5
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	89.0%	72.1%	-16.9
pkg/pod/entrypoint.go	94.1%	93.5%	-0.5

config/config-feature-flags.yaml

chitrangpatel · 2024-03-25T14:15:01Z

/kind feature

tekton-robot · 2024-03-25T14:17:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.1%	-0.5
pkg/apis/pipeline/v1/task_validation.go	98.5%	98.5%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.4%	98.4%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	89.0%	90.6%	1.7
pkg/pod/entrypoint.go	94.1%	93.3%	-0.7

tekton-robot · 2024-03-26T15:59:55Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.1%	-0.5
pkg/apis/pipeline/v1/task_validation.go	98.5%	98.5%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.4%	98.4%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	89.0%	90.6%	1.7
pkg/pod/entrypoint.go	94.1%	93.3%	-0.7

tekton-robot · 2024-03-26T16:01:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.1%	-0.5
pkg/apis/pipeline/v1/task_validation.go	98.5%	98.5%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.4%	98.4%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	89.0%	90.6%	1.7
pkg/pod/entrypoint.go	94.1%	93.3%	-0.7

tekton-robot · 2024-03-26T16:39:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.1%	-0.5
pkg/apis/pipeline/v1/task_validation.go	98.5%	98.5%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.4%	98.4%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	89.0%	90.6%	1.7
pkg/pod/entrypoint.go	94.1%	93.3%	-0.7

tekton-robot · 2024-04-29T17:09:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.0%	-0.6
pkg/apis/pipeline/v1/task_validation.go	98.6%	98.6%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.6%	98.6%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	86.8%	88.2%	1.3
pkg/pod/entrypoint.go	94.1%	93.4%	-0.7

tekton-robot · 2024-04-29T17:10:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.0%	-0.6
pkg/apis/pipeline/v1/task_validation.go	98.6%	98.6%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.6%	98.6%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	86.8%	88.2%	1.3
pkg/pod/entrypoint.go	94.1%	93.4%	-0.7

tekton-robot · 2024-04-29T17:13:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.0%	-0.6
pkg/apis/pipeline/v1/task_validation.go	98.6%	98.6%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.6%	98.6%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	86.8%	88.2%	1.3
pkg/pod/entrypoint.go	94.1%	93.4%	-0.7

tekton-robot · 2024-04-29T17:23:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.0%	-0.6
pkg/apis/pipeline/v1/task_validation.go	98.6%	98.6%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.6%	98.6%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	86.8%	88.2%	1.3
pkg/pod/entrypoint.go	94.1%	93.4%	-0.7

tekton-robot · 2024-04-29T17:25:56Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.0%	-0.6
pkg/apis/pipeline/v1/task_validation.go	98.6%	98.6%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.6%	98.6%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	86.8%	88.2%	1.3
pkg/pod/entrypoint.go	94.1%	93.4%	-0.7

tekton-robot · 2024-06-07T13:30:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.0%	-0.6
pkg/apis/pipeline/v1/task_validation.go	98.6%	98.6%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.6%	98.6%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	86.8%	88.2%	1.3
pkg/pod/entrypoint.go	94.1%	93.4%	-0.7

tekton-robot · 2024-06-07T13:32:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.0%	-0.6
pkg/apis/pipeline/v1/task_validation.go	98.6%	98.6%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.6%	98.6%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	86.8%	88.2%	1.3
pkg/pod/entrypoint.go	94.1%	93.4%	-0.7

ericzzzzzzz · 2024-06-13T15:38:15Z

/hold cancel

ericzzzzzzz · 2024-06-13T15:39:37Z

Hi @vdemeester tep-0156 is merged now, could you another look at this pr? Thanks

docs/stepactions.md

tekton-robot · 2024-06-17T16:35:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.0%	-0.6
pkg/apis/pipeline/v1/task_validation.go	98.6%	98.6%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.6%	98.6%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	86.8%	88.2%	1.3
pkg/pod/entrypoint.go	94.1%	93.4%	-0.7

tekton-robot · 2024-06-17T16:36:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	11.6%	11.0%	-0.6
pkg/apis/pipeline/v1/task_validation.go	98.6%	98.6%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.6%	98.6%	0.0
pkg/container/step_replacements.go	70.0%	72.7%	2.7
pkg/entrypoint/entrypointer.go	86.8%	88.2%	1.3
pkg/pod/entrypoint.go	94.1%	93.4%	-0.7

ericzzzzzzz · 2024-06-21T13:48:30Z

Hi @vdemeester , I updated the doc, please take another look, if you have any other questions, let me know! Thanks!

tekton-robot · 2024-07-03T09:18:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, JeromeJu, khrm, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JeromeJu,chitrangpatel,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chitrangpatel · 2024-07-03T11:51:23Z

/lgtm

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels Mar 11, 2024

tekton-robot requested review from afrittoli and jerop March 11, 2024 17:49

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 11, 2024

chitrangpatel reviewed Mar 11, 2024

View reviewed changes

config/config-feature-flags.yaml Outdated Show resolved Hide resolved

ericzzzzzzz force-pushed the step-when branch from 84570f3 to e9b06b9 Compare March 25, 2024 14:09

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2024

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2024

tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 26, 2024

chitrangpatel added this to the Pipelines v0.59 milestone Mar 26, 2024

ericzzzzzzz force-pushed the step-when branch from 268cb4a to cce277f Compare March 26, 2024 15:53

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024

ericzzzzzzz marked this pull request as ready for review March 26, 2024 15:54

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024

tekton-robot requested review from abayer and pritidesai March 26, 2024 15:54

ericzzzzzzz force-pushed the step-when branch from c9411e6 to 9c31590 Compare April 29, 2024 17:15

chitrangpatel modified the milestones: Pipeline v0.60, Pipeline v0.61 May 15, 2024

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2024

ericzzzzzzz force-pushed the step-when branch from 9c31590 to faec133 Compare June 7, 2024 13:21

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2024

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2024

vdemeester reviewed Jun 17, 2024

View reviewed changes

docs/stepactions.md Outdated Show resolved Hide resolved

feat: introduce when expressions to steps

475d1cc

ericzzzzzzz force-pushed the step-when branch from faec133 to 475d1cc Compare June 17, 2024 16:25

chitrangpatel modified the milestones: Pipeline v0.61, Pipeline v0.62 Jun 25, 2024

vdemeester approved these changes Jul 3, 2024

View reviewed changes

tekton-robot assigned chitrangpatel Jul 3, 2024

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2024

tekton-robot merged commit 5625a6a into tektoncd:main Jul 3, 2024
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: introduce when expressions to steps #7746

feat: introduce when expressions to steps #7746

ericzzzzzzz commented Mar 11, 2024 •

edited

Loading

tekton-robot commented Mar 11, 2024

tekton-robot commented Mar 11, 2024

Changes

Submitter Checklist

Release Notes

tekton-robot commented Mar 11, 2024

tekton-robot commented Mar 11, 2024

tekton-robot commented Mar 11, 2024

chitrangpatel commented Mar 25, 2024

tekton-robot commented Mar 25, 2024

tekton-robot commented Mar 26, 2024

tekton-robot commented Mar 26, 2024

tekton-robot commented Mar 26, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Jun 7, 2024

tekton-robot commented Jun 7, 2024

ericzzzzzzz commented Jun 13, 2024

ericzzzzzzz commented Jun 13, 2024

tekton-robot commented Jun 17, 2024

tekton-robot commented Jun 17, 2024

ericzzzzzzz commented Jun 21, 2024

tekton-robot commented Jul 3, 2024

chitrangpatel commented Jul 3, 2024

feat: introduce when expressions to steps #7746

feat: introduce when expressions to steps #7746

Conversation

ericzzzzzzz commented Mar 11, 2024 • edited Loading

Changes

fixes: #7623

Related

Submitter Checklist

Release Notes

tekton-robot commented Mar 11, 2024

tekton-robot commented Mar 11, 2024

Changes

Submitter Checklist

Release Notes

tekton-robot commented Mar 11, 2024

tekton-robot commented Mar 11, 2024

tekton-robot commented Mar 11, 2024

chitrangpatel commented Mar 25, 2024

tekton-robot commented Mar 25, 2024

tekton-robot commented Mar 26, 2024

tekton-robot commented Mar 26, 2024

tekton-robot commented Mar 26, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Apr 29, 2024

tekton-robot commented Jun 7, 2024

tekton-robot commented Jun 7, 2024

ericzzzzzzz commented Jun 13, 2024

ericzzzzzzz commented Jun 13, 2024

tekton-robot commented Jun 17, 2024

tekton-robot commented Jun 17, 2024

ericzzzzzzz commented Jun 21, 2024

tekton-robot commented Jul 3, 2024

chitrangpatel commented Jul 3, 2024

ericzzzzzzz commented Mar 11, 2024 •

edited

Loading