Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WhenExpression for StepAction #7623

Closed
Tracked by #7424
uqix opened this issue Jan 30, 2024 · 4 comments · Fixed by #7746
Closed
Tracked by #7424

Support WhenExpression for StepAction #7623

uqix opened this issue Jan 30, 2024 · 4 comments · Fixed by #7746
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@uqix
Copy link

uqix commented Jan 30, 2024

Feature request

https://github.com/tektoncd/community/blob/main/teps/0142-enable-step-reusability.md#conditional-execution-of-steps

However, StepActions are generally written more generically and guarding whether to execute the next Step based on a previous Step will be required. This is something we can pursue in the future.

Use case

To reduce pod overhead, we want to rewrite our Pipelines by StepAction, and when is the only remaining blocker here.

@uqix uqix added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 30, 2024
@ericzzzzzzz
Copy link
Contributor

/assign

@ericzzzzzzz
Copy link
Contributor

#7415 is still open, I think we might not include CEL in stepAction at the moment

@chitrangpatel
Copy link
Contributor

#7415 is still open, I think we might not include CEL in stepAction at the moment

I think we should for consistency with PipelineTasks. That issue is tracking its progress to beta. The idea would be that when those are implemented, they would be implemented alike for StepActions and Tasks.

I think the way to think about this is that the filtering mechanism should be consistent across them both. But what (fields) you can filter on is different. e.g. You should be able to use in operator in WhenExpressions for both cases but clearly there are certain fields like Task.Status (for example) that makes no sense for StepActions.

@ericzzzzzzz
Copy link
Contributor

Thanks for the clarification .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants