-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v0.53.x] Do not require enable-api-fields: alpha
for entrypoint cancellation
#7457
[release-v0.53.x] Do not require enable-api-fields: alpha
for entrypoint cancellation
#7457
Conversation
This commit removes the need for `enable-api-fields: alpha` to enable the entrypoint cancellation. This feature should only behind the `keep-pod-on-cancel: true` feature-flag. Signed-off-by: Vincent Demeester <vdemeest@redhat.com> (cherry picked from commit 1b075fb) Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
enable-api-fields: alpha
for entrypoint cancellationenable-api-fields: alpha
for entrypoint cancellation
/kind bug |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeromeJu, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This commit removes the need for
enable-api-fields: alpha
to enable the entrypoint cancellation. This feature should only behind thekeep-pod-on-cancel: true
feature-flag.(cherry picked from commit 1b075fb)
This cherry-picks #7430 manually (as it conflicted).
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes