Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.53.x] Do not require enable-api-fields: alpha for entrypoint cancellation #7457

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 4, 2023

Changes

This commit removes the need for enable-api-fields: alpha to enable the entrypoint cancellation. This feature should only behind the keep-pod-on-cancel: true feature-flag.

(cherry picked from commit 1b075fb)

This cherry-picks #7430 manually (as it conflicted).

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Entrypoint cancellation only requires `keep-pod-on-cancel: true` feature-flag.

This commit removes the need for `enable-api-fields: alpha` to enable
the entrypoint cancellation. This feature should only behind the
`keep-pod-on-cancel: true` feature-flag.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
(cherry picked from commit 1b075fb)
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2023
@tekton-robot tekton-robot requested review from dibyom and jerop December 4, 2023 10:00
@vdemeester vdemeester changed the title Do not require enable-api-fields: alpha for entrypoint cancellation [release-v0.53.x] Do not require enable-api-fields: alpha for entrypoint cancellation Dec 4, 2023
@vdemeester
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 4, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 92.2% 92.7% 0.5
pkg/reconciler/taskrun/taskrun.go 85.6% 85.1% -0.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 92.2% 92.7% 0.5
pkg/reconciler/taskrun/taskrun.go 85.6% 85.1% -0.5

@JeromeJu
Copy link
Member

JeromeJu commented Dec 4, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@tekton-robot tekton-robot merged commit fa8538c into tektoncd:release-v0.53.x Dec 5, 2023
1 check passed
@vdemeester vdemeester deleted the cherry-pick-053-keep-pod-on-cancel-only-featurefalg branch December 5, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants