Do not require enable-api-fields: alpha for entrypoint cancellation

[vdemeester]

Changes

This commit removes the need for enable-api-fields: alpha to enable
the entrypoint cancellation. This feature should only behind the
keep-pod-on-cancel: true feature-flag.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Entrypoint cancellation only requires `keep-pod-on-cancel: true` feature-flag.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JeromeJu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/cherry-pick release-v0.53.x

[tekton-robot]

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.53.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Yongxuanzhang]

/lgtm

[tekton-robot]

@vdemeester: #7430 failed to apply on top of branch "release-v0.53.x":

Applying: Do not require `enable-api-fields: alpha` for entrypoint cancellation
Using index info to reconstruct a base tree...
M	pkg/pod/pod.go
M	pkg/pod/pod_test.go
M	pkg/reconciler/taskrun/taskrun.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/taskrun/taskrun.go
CONFLICT (content): Merge conflict in pkg/reconciler/taskrun/taskrun.go
Auto-merging pkg/pod/pod_test.go
Auto-merging pkg/pod/pod.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Do not require `enable-api-fields: alpha` for entrypoint cancellation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JeromeJu]

@vdemeester: #7430 failed to apply on top of branch "release-v0.53.x":

Applying: Do not require `enable-api-fields: alpha` for entrypoint cancellation
Using index info to reconstruct a base tree...
M	pkg/pod/pod.go
M	pkg/pod/pod_test.go
M	pkg/reconciler/taskrun/taskrun.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/taskrun/taskrun.go
CONFLICT (content): Merge conflict in pkg/reconciler/taskrun/taskrun.go
Auto-merging pkg/pod/pod_test.go
Auto-merging pkg/pod/pod.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Do not require `enable-api-fields: alpha` for entrypoint cancellation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Looks like we'd need a manual cherry-pick on this.