Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PipelineRunReasonFailedValidation with more granular reasons #7417

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Replace PipelineRunReasonFailedValidation with more granular reasons #7417

merged 2 commits into from
Dec 6, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Nov 24, 2023 •
edited
Loading

Changes

Add InvalidPipelineResult PipelineRunReason

This commit adds the PipelineRunReasonInvalidPipelineResult which was
previously conflated in PipelineRunReasonFailedValidation. It is now
separated in order to keep the PipelineRunStatus failure reason
granular.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. labels Nov 24, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 24, 2023
@JeromeJu JeromeJu marked this pull request as draft November 24, 2023 22:49
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2023
@JeromeJu JeromeJu changed the title Add InvalidPipelineResult PipelineRunReason Replace PipelineRunReasonFailedValidation with more granular reasons Nov 24, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@JeromeJu
Copy link
Member Author

part of #7434

@JeromeJu JeromeJu force-pushed the error-sweep-invalid-pipelineresult branch from dbd2acd to 2387dd4 Compare December 5, 2023 20:55
@JeromeJu JeromeJu marked this pull request as ready for review December 5, 2023 20:57
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2023
@tekton-robot tekton-robot requested review from abayer and jerop December 5, 2023 20:57
@JeromeJu
Add CouldntGetPipelineResult PipelineRunReason
5df6250 
This commit adds the PipelineRunReasonCouldntGetPipelineResult which was
previously conflated in PipelineRunReasonFailedValidation. It is now
separated in order to keep the PipelineRunStatus failure reason
granular.

/kind cleanup
@JeromeJu JeromeJu force-pushed the error-sweep-invalid-pipelineresult branch from 2387dd4 to 5df6250 Compare December 5, 2023 21:20
@JeromeJu JeromeJu mentioned this pull request Dec 5, 2023
Merged
7 tasks
Yongxuanzhang
Yongxuanzhang reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@tekton-robot tekton-robot merged commit d1b8f29 into tektoncd:main Dec 6, 2023
3 checks passed
@JeromeJu JeromeJu mentioned this pull request Dec 18, 2023
Open
@JeromeJu JeromeJu mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@abayer abayer Awaiting requested review from abayer

@jerop jerop Awaiting requested review from jerop

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeromeJu @tekton-robot @vdemeester @Yongxuanzhang