Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose conflated user-facing PipelineRunStatus/ TaskRunStatus failure reasons #7434

Closed
2 tasks
JeromeJu opened this issue Nov 28, 2023 · 1 comment
Closed
2 tasks
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Nov 28, 2023

Current behaviour:

There exist PipelineRun and TaskRun failure reasons are conflated with others that are non-related with the description of the PipelineRun and TaskRun reason. For example, as for PipelineRunReasonFailedValidaion which should indicate that the Pipelinerun runtime validation failure mixes up the failure reasons of InvalidPipelineResult and InvalidParamsResolvedPipelineTasks. Similarly for TaskRunFailedValidation conflating InvalidParamArrayIndex and etc. which should have been using clearer failure reasons.

Expected behaviour:

  • Examine the granularity PipelineRunReason/TaskRunReason used in failures in the pipeline reconciler.
    • Ideally, similar to exit codes, each PipelineRunReason and TaskRunReason should be unique and clearly identify the specific failure cause, preventing confusion with other reasons.
  • Break down the conflated failure PipelineRun/TaskRun Reasons according to the root failure causes.

/kind cleanup

@JeromeJu
Copy link
Member Author

JeromeJu commented Feb 6, 2024

Closing as covered in #7501 and continued at TEP0151-Error attribution via Condition Status

@JeromeJu JeromeJu closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants