Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout in Conversion Integration Test to Prevent Flake #6026

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jan 24, 2023

Changes

This commit increases the timeout length in conversion_test to prevent flake in that pipeline could fail waiting for the TaskRun to get done given the previous timeout.

Potential flake observed at:
https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6022/pull-tekton-pipeline-integration-tests/1617909197544886272

    stream.go:254: D 15:51:47.598 tekton-pipelines-controller-5cc86f7df8-tcwgv [github.com.tektoncd.pipeline.pkg.reconciler.pipelinerun.Reconciler] [arendelle-xrpr8/git-resolver-clone-vktppyly] tracerProvider doesn't provide a traceId, tracing is disabled
=== CONT  TestTaskRunCRDConversion
    conversion_test.go:869: Failed waiting for v1beta1 TaskRun done: "task-run-c-r-d-conversion-wskyiehs" failed
    panic.go:500: ############################################
    panic.go:500: ### Dumping objects from arendelle-msvkl ###
    panic.go:500: ############################################

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

This commit increases the `timeout` length in conversion_test to prevent
flake that pipeline could fail waiting for the TaskRun to get done.
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2023
@Yongxuanzhang
Copy link
Member

/lgtm
the error msg is TaskRun "task-run-c-r-d-conversion-wskyiehs" failed to finish within "20s", it makes sense to increase the timeout to avoid this failure

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JeromeJu

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@jerop jerop closed this Feb 15, 2023
@jerop jerop reopened this Feb 15, 2023
@tekton-robot tekton-robot merged commit 3883688 into tektoncd:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants