Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPipelineRunCRDConversion is flake #6672

Closed
Yongxuanzhang opened this issue May 16, 2023 · 3 comments · Fixed by #6714
Closed

TestPipelineRunCRDConversion is flake #6672

Yongxuanzhang opened this issue May 16, 2023 · 3 comments · Fixed by #6714
Labels
kind/flake Categorizes issue or PR as related to a flakey test

Comments

@Yongxuanzhang
Copy link
Member

Logs: https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6663/pull-tekton-pipeline-alpha-integration-tests/1658558758315364352

Example PR where the test failed: #6663

Relevant Logs:

    conversion_test.go:910: Failed waiting for v1 pipelineRun done: "pipeline-run-c-r-d-conversion-wgsdqpcl" failed
    panic.go:540: ############################################
    panic.go:540: ### Dumping objects from arendelle-fqvtt ###
    panic.go:540: ############################################
         conditions:
          - lastTransitionTime: "2023-05-16T20:02:20Z"
            message: PipelineRun "pipeline-run-c-r-d-conversion-wgsdqpcl" failed to finish
              within "1m0s"
            reason: PipelineRunTimeout
            status: "False"
            type: Succeeded

/kind flake

@tekton-robot tekton-robot added the kind/flake Categorizes issue or PR as related to a flakey test label May 16, 2023
@JeromeJu
Copy link
Member

Thanks @Yongxuanzhang , seems the actual flake was TestPipelineRunCRDConversion . I previously thought 60s should be enough for the wait time but I guess it is not 🤔 ? :/

@Yongxuanzhang Yongxuanzhang changed the title TestTaskCRDConversion is flake TestPipelineRunCRDConversion is flake May 17, 2023
@Yongxuanzhang
Copy link
Member Author

Thanks @Yongxuanzhang , seems the actual flake was TestPipelineRunCRDConversion . I previously thought 60s should be enough for the wait time but I guess it is not 🤔 ? :/

Oh yes, I'm not sure.. so it was incremented to 60s before?

@JeromeJu
Copy link
Member

Thanks @Yongxuanzhang , seems the actual flake was TestPipelineRunCRDConversion . I previously thought 60s should be enough for the wait time but I guess it is not 🤔 ? :/

Oh yes, I'm not sure.. so it was incremented to 60s before?

Alike #6026 . going to look into this specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/flake Categorizes issue or PR as related to a flakey test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants