Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating release cheat sheet #4322

Merged
merged 1 commit into from
Oct 20, 2021
Merged

updating release cheat sheet #4322

merged 1 commit into from
Oct 20, 2021

Conversation

pritidesai
Copy link
Member

@pritidesai pritidesai commented Oct 19, 2021 •
edited
Loading

Changes

Add a new item as part of the release creation process, creating a branch in the GitHub repo for the release that was just created.

This branch can be useful to the website https://tekton.dev/docs/ to point to the latest release. Also, the released branch is needed for creating a patch. Instead of creating such branch just before creating a patch, make it part of the release process.

Closes #3875

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Updated the release cheat sheet to include creating a GitHub release branch such as release-v0.28.x as part of the release creation process.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. labels Oct 19, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2021
@pritidesai
Copy link
Member Author 

<HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
        <TITLE>301 Moved</TITLE></HEAD><BODY>
        <H1>301 Moved</H1>
        The document has moved
        <A HREF="http://www.google.com/">here</A>.
        </BODY></HTML>
    build_logs.go:35: Could not get logs for pod not-hermetic-run-as-root-pod-ldcp6: pods "not-hermetic-run-as-root-pod-ldcp6" not found

/test pull-tekton-pipeline-alpha-integration-tests

jerop
jerop approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pritidesai!

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@jerop
Copy link
Member

jerop commented Oct 19, 2021 •
edited
Loading

examples_test.go:62: Failed waiting for task run done: "workspace-in-sidecar-rtmjf" failed --> test is known to be flaky as reported in #4169, added a report in #4169 (comment)

/test pull-tekton-pipeline-alpha-integration-tests

jerop
jerop reviewed Oct 19, 2021
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed a typo in the cheatsheet that haven't gotten around to fixing, could we fix it here please in case someone copy pastes and misses the typo?

pipeline/tekton/release-cheat-sheet.md

Line 181 in f53f4fb

kubectl config rename-context gke_tekton-releases_us-central1-a_dogfooding dogfoodin

dogfoodin --> dogfooding

@pritidesai
updating release cheat sheet
1a81742 
Add a new item as part of the release creation process, creating a branch
in the GitHub repo for the release that was just created.

This branch can be useful to the website https://tekton.dev/docs/ to point to
the latest release. Also, the released branch is needed for creating a patch.
Instead of creating such branch just before creating a patch, make it part of
the release process.

Fixing the typo while renaming the context to dogfooding instead of dogfoodin (typo)
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dlorenc
Copy link
Contributor

dlorenc commented Oct 20, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@tekton-robot tekton-robot merged commit 0a19aa3 into tektoncd:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@dlorenc dlorenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation on Release Branches / Tagging
5 participants
@pritidesai @jerop @tekton-robot @dlorenc @vdemeester