Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0114: Custom Tasks Beta - Remove Pod Template #815

Merged
merged 1 commit into from
Sep 8, 2022
Merged

TEP-0114: Custom Tasks Beta - Remove Pod Template #815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions teps/0114-custom-tasks-beta.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ see-also:
- [API Changes](#api-changes)
- [v1alpha1 to v1beta1 + Run to CustomRun](#v1alpha1-to-v1beta1--run-to-customrun)
- [References and Specifications](#references-and-specifications)
- [Remove Pod Template](#remove-pod-template)
- [Feature Gates](#feature-gates)
- [Documentation](#documentation)
- [Testing](#testing)
Expand Down Expand Up @@ -191,6 +192,14 @@ spec:
Simplifying all the references to use `ref` and embedded specifications to use `spec` is out of scope for this TEP. That
work is tracked in [tektoncd/pipeline#5138][5138].

##### Remove Pod Template

Remove `podTemplate` field that assumes and implies that all `Custom Tasks` create `Pods`.

Note that the goal of `Custom Tasks`, as defined in [TEP-0002][tep-0002], is to support non-Pod `Task` implementations.
If a specific `Custom Task` implementation creates `Pods`, that `Custom Task` can have a `Pod` template field in its
own specification.

##### Feature Gates

Remove guarding of `Custom Tasks` behind `enable-custom-tasks` and `enable-api-fields` feature gates.
Expand Down