-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEP-0114: Custom Tasks Beta - Remove Pod Template #815
Conversation
In v1alpha1, `Runs` have `Pod` templates. However, `Runs` do not always create `Pods`. In this change, we propose that `Runs` in v1beta1 should not have `Pod` templates - specific `Custom Tasks` implementation can support that in their own specifications. Context: tektoncd/pipeline#5403 (comment) Many thanks to @lbernick for catching this issue!
/assign thanks Jerop! right now, podtemplate and serviceaccountname are passed to runs through taskRunSpecs. It might be out of scope for this PR, but do you think we should create |
@lbernick this is a great idea, imo we should decouple it from the promotion to beta -- we can create an issue to track that work post-promotion so that we'll have a chance to discuss the feature and its use cases in further detail |
Sounds good! Created tektoncd/pipeline#5447 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
In v1alpha1,
Runs
havePod
templates. However,Runs
do not always createPods
.In this change, we propose that
Runs
in v1beta1 should not havePod
templates - specificCustom Tasks
implementation can support that in their own specifications.Context: tektoncd/pipeline#5403 (comment)
Many thanks to @lbernick for catching this issue!
/kind tep
cc @vsinghai @lbernick @vdemeester