Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0114: Custom Tasks Beta - Remove Pod Template #815

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Sep 6, 2022

In v1alpha1, Runs have Pod templates. However, Runs do not always create Pods.

In this change, we propose that Runs in v1beta1 should not have Pod templates - specific Custom Tasks implementation can support that in their own specifications.

Context: tektoncd/pipeline#5403 (comment)

Many thanks to @lbernick for catching this issue!

/kind tep

cc @vsinghai @lbernick @vdemeester

In v1alpha1, `Runs` have `Pod` templates. However, `Runs` do not
always create `Pods`. In this change, we propose that `Runs` in
v1beta1 should not have `Pod` templates - specific `Custom Tasks`
implementation can support that in their own specifications.

Context: tektoncd/pipeline#5403 (comment)

Many thanks to @lbernick for catching this issue!
@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Sep 6, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2022
@lbernick
Copy link
Member

lbernick commented Sep 6, 2022

/assign
/approve

thanks Jerop! right now, podtemplate and serviceaccountname are passed to runs through taskRunSpecs. It might be out of scope for this PR, but do you think we should create pipelineRun.spec.runSpecs?

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@jerop
Copy link
Member Author

jerop commented Sep 6, 2022

thanks Jerop! right now, podtemplate and serviceaccountname are passed to runs through taskRunSpecs. It might be out of scope for this PR, but do you think we should create pipelineRun.spec.runSpecs?

@lbernick this is a great idea, imo we should decouple it from the promotion to beta -- we can create an issue to track that work post-promotion so that we'll have a chance to discuss the feature and its use cases in further detail

@lbernick
Copy link
Member

lbernick commented Sep 7, 2022

this is a great idea, imo we should decouple it from the promotion to beta -- we can create an issue to track that work post-promotion so that we'll have a chance to discuss the feature and its use cases in further detail

Sounds good! Created tektoncd/pipeline#5447

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lbernick
Copy link
Member

lbernick commented Sep 8, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@tekton-robot tekton-robot merged commit 4312b76 into tektoncd:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: UnAssigned
Development

Successfully merging this pull request may close these issues.

4 participants