Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP0122] Add feature flags field to Invocation.Environment #720

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[TEP0122] Add feature flags field to Invocation.Environment #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion pkg/chains/formats/slsa/v2/taskrun/taskrun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,32 @@ func GenerateAttestation(builderID string, payloadType config.PayloadType, tro *
// which material the Task definition came from
func invocation(tro *objects.TaskRunObject) slsa.ProvenanceInvocation {
i := slsa.ProvenanceInvocation{}
if p := tro.Status.Provenance; p != nil {
if p := tro.Status.Provenance; p != nil && p.ConfigSource != nil {
i.ConfigSource = slsa.ConfigSource{
URI: p.ConfigSource.URI,
Digest: p.ConfigSource.Digest,
EntryPoint: p.ConfigSource.EntryPoint,
}
}
i.Parameters = invocationParams(tro)
env := invocationEnv(tro)
if len(env) > 0 {
i.Environment = env
}
return i
}

// invocationEnv adds the tekton feature flags that were enabled
// for the taskrun. In the future, we can populate versioning information
// here as well.
func invocationEnv(tro *objects.TaskRunObject) map[string]any {
var iEnv map[string]any = make(map[string]any)
if tro.Status.Provenance != nil && tro.Status.Provenance.FeatureFlags != nil {
iEnv["tekton-pipelines-feature-flags"] = tro.Status.Provenance.FeatureFlags
}
return iEnv
}

// invocationParams adds all fields from the task run object except
// TaskRef or TaskSpec since they are in the ConfigSource or buildConfig.
func invocationParams(tro *objects.TaskRunObject) map[string]any {
Expand Down
23 changes: 23 additions & 0 deletions pkg/chains/formats/slsa/v2/taskrun/taskrun_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
"github.com/tektoncd/chains/pkg/chains/formats/slsa/extract"
slsav1 "github.com/tektoncd/chains/pkg/chains/formats/slsa/v1/taskrun"
"github.com/tektoncd/chains/pkg/chains/objects"
"github.com/tektoncd/pipeline/pkg/apis/config"
"github.com/tektoncd/pipeline/pkg/apis/pipeline/pod"
"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
"github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1"
Expand Down Expand Up @@ -152,6 +153,16 @@ status:
- name: my-default-empty-array-param
type: array
default: []
provenance:
featureFlags:
AwaitSidecarReadiness: true
CustomTaskVersion: v1beta1
EnableAPIFields: stable
EnableProvenanceInStatus: true
MaxResultSize: 4096
ResourceVerificationMode: skip
ResultExtractionMethod: termination-message
RunningInEnvWithInjectedSidecars: true
`

var taskRun *v1beta1.TaskRun
Expand Down Expand Up @@ -189,6 +200,18 @@ status:
"Timeout": (*metav1.Duration)(nil),
"Workspaces": []v1beta1.WorkspaceBinding(nil),
},
Environment: map[string]any{
"tekton-pipelines-feature-flags": &config.FeatureFlags{
RunningInEnvWithInjectedSidecars: true,
EnableAPIFields: "stable",
AwaitSidecarReadiness: true,
ResourceVerificationMode: "skip",
EnableProvenanceInStatus: true,
ResultExtractionMethod: "termination-message",
MaxResultSize: 4096,
CustomTaskVersion: "v1beta1",
},
},
}
got := invocation(objects.NewTaskRunObject(taskRun))
if !reflect.DeepEqual(expected, got) {
Expand Down