Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP0122] Add feature flags field to Invocation.Environment #720

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[TEP0122] Add feature flags field to Invocation.Environment #720

merged 1 commit into from
Feb 23, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Feb 22, 2023 •
edited
Loading

For completeness of build instructions, Tekton Chains needs to pick up the feature flags used for the build. This PR adds it to invocation.Environment section of the slsav0.2 predicate. Like ConfigSource, this field is only populated if the feature flag: enable-provenance-in-status is set to "true".

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add feature flags field to Invocation.Environment

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 22, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2023
@chitrangpatel chitrangpatel marked this pull request as draft February 22, 2023 16:38
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2023
@chitrangpatel chitrangpatel mentioned this pull request Feb 22, 2023
Closed
6 tasks
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v2/taskrun/taskrun.go 60.0% 70.4% 10.4
pkg/reconciler/pipelinerun/pipelinerun.go 75.6% 82.9% 7.2

@chitrangpatel
Copy link
Contributor Author

/hold wait for #712 to be merged first (until EOW, minimum)

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@chitrangpatel chitrangpatel marked this pull request as ready for review February 22, 2023 16:57
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v2/taskrun/taskrun.go 60.0% 70.4% 10.4
pkg/reconciler/pipelinerun/pipelinerun.go 75.6% 82.9% 7.2

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2023
@chitrangpatel
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v2/taskrun/taskrun.go 60.0% 70.4% 10.4

@wlynch
Copy link
Member

wlynch commented Feb 23, 2023

We should also start thinking about how we want to document the provenance format: having an example in the readme might go a long way!

(long term I want to look into generating an OpenAPI schema for the provenance we're producing)

@chitrangpatel
[TEP0122] Adds feature flags field to Invocation.Environment
1377faf 
For completeness of build instructions, Tekton Chains needs to pick up the feature flags used for the build. This PR adds it to `invocation.Environment` section of the slsav0.2 predicate. Like ConfigSource, this field is only populated if the feature flag: `enable-provenance-in-status` is set to `"true"`.
@chitrangpatel
Copy link
Contributor Author

chitrangpatel commented Feb 23, 2023 •
edited
Loading

We should also start thinking about how we want to document the provenance format: having an example in the readme might go a long way!

(long term I want to look into generating an OpenAPI schema for the provenance we're producing)

Sounds good! Now that this is complete, I can add a section in https://github.com/tektoncd/chains/blob/main/pkg/chains/formats/slsa/README.md to show an example as a part of a follow-up PR. After we move it from slsav2alpha1 to slsav2, we can surface the example in the docs.

wlynch
wlynch approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/v2/taskrun/taskrun.go 60.0% 70.4% 10.4

@tekton-robot tekton-robot merged commit ee8ca6c into tektoncd:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

@chuangw6 chuangw6 Awaiting requested review from chuangw6

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chitrangpatel @tekton-robot @wlynch