Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add when field to inherited fields of all plugins #3439

Merged
merged 1 commit into from
Jan 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/scripts/generate-plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def _is_inherited(

# TODO: for now, it's a list, but inspecting the actual tree of classes
# would be more generic. It's good enough for now.
return field.name in ('name', 'where', 'order', 'summary', 'enabled', 'result')
return field.name in ('name', 'where', 'when', 'order', 'summary', 'enabled', 'result')


def container_ignored_fields(container: ContainerClass) -> list[str]:
Expand Down
Loading