Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add when field to inherited fields of all plugins #3439

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

happz
Copy link
Collaborator

@happz happz commented Jan 2, 2025

Added recently, this field is accepted for all phases, and sice we do not detect inherited fields but use a static list, the list needs to be extended to avoid showing the field in every plugin's docs.

Pull Request Checklist

  • implement the feature

@happz happz added the documentation Improvements or additions to documentation label Jan 2, 2025
@happz happz added this to the 1.41 milestone Jan 2, 2025
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 7, 2025
Added recently, this field is accepted for all phases, and sice we do
not detect inherited fields but use a static list, the list needs to be
extended to avoid showing the field in every plugin's docs.
@happz happz force-pushed the plugin-when-field-is-inherited branch from 39f403d to 4ca98b5 Compare January 7, 2025 13:16
@happz happz merged commit 2af39b3 into main Jan 7, 2025
9 of 20 checks passed
@happz happz deleted the plugin-when-field-is-inherited branch January 7, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants