Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS 6.4.0 Empty String Range Error #431

Closed
spanditcaa opened this issue Aug 17, 2016 · 5 comments
Closed

NodeJS 6.4.0 Empty String Range Error #431

spanditcaa opened this issue Aug 17, 2016 · 5 comments

Comments

@spanditcaa
Copy link
Member

We are seeing errors (stack below) from tedious in our API under node 6.4 due to this new bug:

nodejs/node#8127

It sounds like this will be fixed in node, a fix isn't necessary in tedious but I wanted to share the finding.

RangeError: Offset is out of bounds
    at RangeError (native)
    at Buffer.write (buffer.js:778:21)
    at WritableTrackingBuffer.writeString (\node_modules\tedious\lib\tracking-buffer\writable-tracking-buffer.js:216:38)
    at Login7Payload.addVariableDataString (\node_modules\tedious\lib\login7-payload.js:228:25)
    at Login7Payload.createVariableData (\node_modules\tedious\lib\login7-payload.js:194:12)
    at new Login7Payload (\node_modules\tedious\lib\login7-payload.js:111:25)
    at Connection.sendLogin7Packet (\node_modules\tedious\lib\connection.js:602:21)
    at Connection.message (\node_modules\tedious\lib\connection.js:1054:16)
    at Connection.dispatchEvent (\node_modules\tedious\lib\connection.js:519:45)
    at MessageIO.<anonymous> (\node_modules\tedious\lib\connection.js:439:23)
    at emitNone (events.js:86:13)
    at MessageIO.emit (events.js:185:7)
    at ReadablePacketStream.<anonymous> (\node_modules\tedious\lib\message-io.js:92:15)
    at emitOne (events.js:96:13)
    at ReadablePacketStream.emit (events.js:188:7)
    at readableAddChunk (\node_modules\tedious\node_modules\readable-stream\lib\_stream_readable.js:198:18)
    at ReadablePacketStream.Readable.push (\node_modules\tedious\node_modules\readable-stream\lib\_stream_readable.js:157:10)
    at ReadablePacketStream.Transform.push (\node_modules\tedious\node_modules\readable-stream\lib\_stream_transform.js:123:32)
    at ReadablePacketStream._transform (\node_modules\tedious\lib\message-io.js:57:16)
    at ReadablePacketStream.Transform._read (\node_modules\tedious\node_modules\readable-stream\lib\_stream_transform.js:159:10)
    at ReadablePacketStream.Transform._write (\node_modules\tedious\node_modules\readable-stream\lib\_stream_transform.js:147:83)
    at doWrite (\node_modules\tedious\node_modules\readable-stream\lib\_stream_writable.js:313:64)
@mkraft
Copy link

mkraft commented Aug 19, 2016

I'm experiencing the same bug.

@justinschuldt
Copy link

Just updated to node 6.4.0, am getting this too

@spanditcaa
Copy link
Member Author

nodejs/node#8154 is the fix and should be in node 6.4.1

@arthurschreiber
Copy link
Collaborator

It looks like there won't be any 6.4.1 release, but 6.5.0 will get released soon and contains the fix for this issue. See nodejs/node#8253

arthurschreiber added a commit that referenced this issue Aug 26, 2016
Node.js 6.4.0 was shipped with a bug in it's Buffer implementation that causes the tedious test cases to fail. See #431, nodejs/node#8127 and nodejs/node#8154.
@spanditcaa
Copy link
Member Author

Working normally with node 6.5.0.

tvrprasad pushed a commit to tvrprasad/tedious that referenced this issue Sep 11, 2016
Node.js 6.4.0 was shipped with a bug in it's Buffer implementation that causes the tedious test cases to fail. See tediousjs#431, nodejs/node#8127 and nodejs/node#8154.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants