Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Support for Node 6?? #372

Closed
robbyoconnor opened this issue May 4, 2016 · 20 comments
Closed

Support for Node 6?? #372

robbyoconnor opened this issue May 4, 2016 · 20 comments

Comments

@robbyoconnor
Copy link

Does this support Node v6? I know it support Node 5 -- but not 6

@rpalanki
Copy link

with node 6, OS X-10.10.2, I am getting the following error

dlopen(.../ldapjs/node_modules/dtrace-provider/build/Release/DTraceProviderBindings.node, 1): no suitable image found. Did find: ...ldapjs/node_modules/dtrace-provider/build/Release/DTraceProviderBindings.node: mach-o, but wrong architecture

Any hints?

@jcheng5
Copy link

jcheng5 commented Jul 25, 2016

@rpalanki Does npm rebuild fix the problem?

@robbyoconnor
Copy link
Author

It failed on Travis CI for me

@rpalanki
Copy link

I had to set the environmental variable ARCH before doing npm install. without setting that, its downloading 32 bit version even though my mac is 64 bit.

@robbyoconnor
Copy link
Author

Did any of the participants on this issue see their tests fail on Travis CI on Node 6?

@robbyoconnor
Copy link
Author

I've seen some my tests fail under node 6

I test against: Node 0.12, 4, and 5.

@felixfbecker
Copy link

Could at least the LTS versions 4 and 6 be added to the Travis build matrix?

@robbyoconnor
Copy link
Author

If that's directed at me, I did and it made the build red.

@felixfbecker
Copy link

felixfbecker commented Sep 15, 2016

@robbyoconnor it was directed at the maintainers. I am running ldapjs fine with NodeJS 6 though. What is the actual failure? Do you have a PR open?

@robbyoconnor
Copy link
Author

robbyoconnor commented Sep 15, 2016

@felixfbecker I am too...as I said, I run it successfully with node 0.12, 4, and 5 but fails on 6, and only 6...

@felixfbecker
Copy link

It doesn't fail with 6 for me, I actually have it in production with 6. So I would be very interested in what can cause a crash?

@gmcdowell
Copy link

FYI there is a bug in Node v6.4 which I can across, as it happens in the
context of ldapjs.
It is fixed in v6.5

nodejs/node#8253
tediousjs/tedious#431

On 16 September 2016 at 08:34, Felix Becker notifications@github.com
wrote:

It doesn't fail with 6 for me, I actually have it in production with 6. So
I would be very interested in what can cause a crash?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#372 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJog2BKf_pE_0J7Ce4J18K3Logbib5rCks5qqau7gaJpZM4IW3aM
.


Greg McDowell

Tierra Technologies Ltd

New Zealand Transport Agency approved Electronic Logbook system

CAUTION: This e-mail message and accompanying data may contain information
that is confidential and subject to privilege. If you are not the intended
recipient, you are notified that any use, dissemination, distribution or
copying of this message or data is prohibited. If you have received this
e-mail in error, please notify the sender immediately and delete all
material pertaining to this e-mail. Tierra Technologies Ltd will not accept
liability for any loss or damage caused by using any material or
attachments contained in this message. While every best practice has been
taken, no warranty is made that this material is free from computer virus
or other defect. Tierra Technologies’ entire liability will be limited to
resupplying the material.

@felixfbecker
Copy link

6.5 was just released. Maybe someone open a PR to add Node 6 to the Travis matrix?

@robbyoconnor
Copy link
Author

@robbyoconnor
Copy link
Author

robbyoconnor commented Sep 18, 2016

#389

@felixfbecker
Copy link

@robbyoconnor the build used Node 6.0.0, what if you run it against latest?

@robbyoconnor
Copy link
Author

robbyoconnor commented Sep 18, 2016

https://travis-ci.org/robbyoconnor/openmrs-contrib-id/jobs/160908533

Didn't wanna spam the main project travis

@robbyoconnor
Copy link
Author

Okay, it has to be the way my tests are written...it works in the app. Nevermind I guess..

@robbyoconnor
Copy link
Author

I tracked this down to an error in my codebase...closing

@jsumners
Copy link
Member

⚠️ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.

Please include a minimal reproducible example
when opening a new issue.

@ldapjs ldapjs locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants