-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pending_version state handling, Fix getGist async issue #11
Conversation
* fix: typo * feat: Update get_app_state logic from in_review, pending * feat: Add test code * feat: Add test code * feat: Add test code * feat: Add test code * feat: Add latest_version_info to fetch_app_status * fix: typo
* feat: Add await when getGist * feat: Add await to request * feat: Add request-promise-native * fix: request for awat in check_status.js * fix: writeFile in check_status.js
* feat: Add await to check_status.js * feat: Add await to updateGist in check_status.js * feat: Add main func to check_status.js * feat: Add async to checkVersion * feat: Add async when db on load * fix: check_status.js
# Conflicts: # .github/workflows/fetch.yml # Sources/slack.js
@k-lpmg Thanks for contribution again! I will check this feature soon. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 💯 Thanks for contributions @k-lpmg !
in_review_version_info = app.get_in_review_app_store_version | ||
pending_version_info = app.get_pending_release_app_store_version | ||
latest_version_info = app.get_latest_app_store_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that. get_in_review_app_store_version
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_in_review_app_store_version
returns the status when the app store reviewer has started the build review process.
Features
1. auto-indent to sources
2. fix fetch_app_state
fetch_app_status.rb
3. getGist async issue
getGist
is executed asynchronously and the response is slower than execution ofexec fetch_app_status
, there is a case where the contents of the gist cannot be loaded and the duplicate app state is sent to Slack.Third party
+ "request-promise-native": "^1.0.9"
PR Links