Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual trigger for github action #10

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Conversation

k-lpmg
Copy link
Contributor

@k-lpmg k-lpmg commented Jan 27, 2022

Feature

Add manual trigger button for testing

Screen Shot 2022-01-27 at 7 12 23 PM

@k-lpmg k-lpmg closed this Jan 27, 2022
@techinpark
Copy link
Owner

@k-lpmg Thank you for your contribution. Why did you close it?

@k-lpmg
Copy link
Contributor Author

k-lpmg commented Jan 28, 2022

Hi @techinpark

const db = dirty('store.db').on('load', function(){

The above code was executed, the following error occurred in the github action.

So I looked into the cause and tried to post a PR again, but do you know what kind of issue it is?

Screen Shot 2022-01-28 at 9 45 38 AM

@k-lpmg k-lpmg reopened this Jan 28, 2022
@k-lpmg k-lpmg closed this Jan 28, 2022
@k-lpmg k-lpmg reopened this Jan 28, 2022
@k-lpmg
Copy link
Contributor Author

k-lpmg commented Jan 28, 2022

I tried again on the master branch and it worked fine.
It seems to be an issue that occurred while changing the code because there was an issue with the initial setup.

https://github.com/rogerluan/app-store-connect-notifier/blob/d93b8f2f9c8a1a08eb92aac5fe53835419a27e3b/src/fetch_app_status.rb#L57-L73

As an additional question, https://github.com/rogerluan/app-store-connect-notifier uses get_latest_app_store_version in get_version_info(app), but in the repo, is there a reason to put a logic branch using codes such as get_live_app_store_version, get_edit_app_store_version, get_app_store_versions?

The reason for asking this question was the version in the PENDING_DEVELOPER_RELEASE state, and get_app_state(app) returned the contents of the previous version uploaded to the store.

@techinpark
Copy link
Owner

The reason for asking this question was the version in the PENDING_DEVELOPER_RELEASE state, and get_app_state returned the contents of the previous version uploaded to the store.

@k-lpmg correct! know the problem and need to resolve it.

@k-lpmg
Copy link
Contributor Author

k-lpmg commented Jan 28, 2022

Can't get_latest_app_store_version solve it right now? I wonder if there will be other side effects.

I'd be happy if this issue was resolved quickly!

@techinpark
Copy link
Owner

@k-lpmg I will resolve this issue as soon thank you.

@techinpark techinpark self-requested a review January 28, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants