respond_to? doesn't return true for dynamic methods added by method_missing #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tcocca Any chance you can merge this? Just rebased. |
tcocca
added a commit
that referenced
this pull request
Dec 5, 2013
respond_to? doesn't return true for dynamic methods added by method_missing
|
@petergoldstein Thanks for the help and rebasing. I just released a 0.2.1 version: http://rubygems.org/gems/acts_as_follower |
|
@tcocca Great, thanks. |
|
Thank you for this. I just bumped heads with this last night using a Draper decorated object. acts_as_follower v0.2.1 resolves this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both acts_as_follower and acts_as followable method_missing is overridden to add dynamic methods to the class. But respond_to? returns false when called with the symbols for these dynamic methods.
This pull request update respond_to? to behave correctly.
Please note that this pull request also contains a gemspec update required to get the tests to run green. This gemspec change was designed to just get the tests running, and it should be replaced by the gemspec changes in this pull request if they are both pulled in.
Thanks.