Upgrades for library compatibility #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tcocca Are you still maintaining this gem? Or should we look into forking this? I'd really like to get a gem with several of these PRs pulled in. Thanks. |
|
+1 |
…cro, and allow Rails versions > 3.0.x
|
This PR has basically been outstripped by subsequent development. The master branch has been updated to Rails 4, FactoryGirl has been updated, etc. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a few changes:
i) Eliminating use of the now removed should_change macro in the tests
ii) Updating the use of FactoryGirl to use the new syntax rather than the older syntax that is not supported in the latest versions of the FactoryGirl gem
iii) Editing the gemspec to support Rails versions greater than 3.0.x
iv) Adding a .travis.yml file
It would be great if this could be pulled in and a new gem version released. I'm looking to use this gem on a new Rails 3.2 project.
Please let me know if there's anything else I can do to make that happen. Thanks.