Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New icon? #47

Closed
bertob opened this issue Dec 29, 2020 · 8 comments · Fixed by #53
Closed

New icon? #47

bertob opened this issue Dec 29, 2020 · 8 comments · Fixed by #53

Comments

@bertob
Copy link
Contributor

bertob commented Dec 29, 2020

The current icon is pretty good, but it's a little off the grid. Here's an attempt at fitting it onto the square icon template:

image
@tchx84
Copy link
Owner

tchx84 commented Dec 29, 2020

Let's ship it! Send a PR ?

@ahoneybun
Copy link

I don't really think it fits with the current GNOME icon set tbh.

@bertob bertob mentioned this issue Dec 29, 2020
Merged
tchx84 pushed a commit to bertob/Portfolio that referenced this issue Dec 30, 2020
@bertob @tchx84
data: Add new icon
75c8c41 
* Fix grid alignment.
* Minor style tweaks.
* Add symbolic version.

Closes tchx84#47
tchx84 added a commit to bertob/Portfolio that referenced this issue Dec 30, 2020
@tchx84
data: Install new symbolic icon
95d9cda 
Closes tchx84#47
tchx84 pushed a commit that referenced this issue Dec 30, 2020
@bertob @tchx84
data: Add new icon
a82bbf9 
* Fix grid alignment.
* Minor style tweaks.
* Add symbolic version.

Closes #47
tchx84 added a commit that referenced this issue Dec 30, 2020
@tchx84
data: Install new symbolic icon
a66b29f 
Closes #47
@julianfairfax
Copy link

I don't really think it fits with the current GNOME icon set tbh.

For what it's worth I still don't think it does. Even compared to other mobile Linux apps, it just doesn't fit in: PapirusDevelopmentTeam/papirus-icon-theme#2747

@tchx84
Copy link
Owner

tchx84 commented Sep 11, 2021

I like the latest version, I think is much prettier.

@julianfairfax
Copy link

I think so as well, but I still like it looks too different compared to other icons. I'm not a designer, so I don't necessarily know what makes me think that, but it really jumps out at me.

@julianfairfax
Copy link

@ahoneybun What do you think of the new icon, since you were the one to make the comment about it fitting in with the GNOME icon set?

@ahoneybun
Copy link

I think it has too many harsh shadows which doesn't match the set well but it's tough since it's not an official GNOME app anyway.

@julianfairfax
Copy link

Yeah I can see that now that you point it out. It should be more flat. I think that's what makes it stand out even with the other icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

app icon: fix grid alignment, minor style tweaks, add symoblic bertob/Portfolio
4 participants
@tchx84 @bertob @ahoneybun @julianfairfax