Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Tchap architecture with the Element one, and plug the rooms list to the rooms fetchers #484

Merged
merged 14 commits into from
Mar 30, 2022
Merged

Update the Tchap architecture with the Element one, and plug the rooms list to the rooms fetchers #484

merged 14 commits into from
Mar 30, 2022

Conversation

phloux
Copy link

@phloux phloux commented Mar 24, 2022

@phloux phloux requested a review from giomfo March 25, 2022 09:57
@giomfo giomfo self-assigned this Mar 25, 2022
This was referenced Mar 28, 2022
Closed
Closed
Closed
Closed
Closed
giomfo
giomfo approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment that we can discuss about
I listed the observed issues that we will have to consider after the merge

Riot/Modules/Application/AppDelegate.swift Outdated
@@ -18,7 +18,7 @@ import UIKit
import PushKit

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {
class AppDelegate: UIResponder, UIApplicationDelegate, PushNotificationServiceDelegate {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove PushNotificationServiceDelegate here, it is already handled by LegacyAppDelegate

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in last commit

Riot/Modules/Application/AppDelegate.swift Outdated
@@ -122,4 +125,9 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
func application(_ application: UIApplication, didReceiveRemoteNotification userInfo: [AnyHashable: Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
self.legacyAppDelegate.application(application, didReceiveRemoteNotification: userInfo, fetchCompletionHandler: completionHandler)
}

@objc func pushNotificationService(_ pushNotificationService: PushNotificationService, shouldNavigateToRoomWithId roomId: String) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be removed now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in last commit

@phloux phloux merged commit af965b4 into develop Mar 30, 2022
@phloux phloux deleted the phlpro/rebase_arch branch March 30, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

Assignees

@giomfo giomfo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phloux @giomfo