Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the session verification based on the secure storage #486

Closed
giomfo opened this issue Mar 28, 2022 · 2 comments
Closed

Hide the session verification based on the secure storage #486

giomfo opened this issue Mar 28, 2022 · 2 comments
Labels
iOS

Comments

@giomfo
Copy link
Contributor

giomfo commented Mar 28, 2022

Following #484, the user is prompted to verify the new session when the application is started

image

Can you please confirm this dialog is related to the secure storage implementation?
When I select "Verifiy" nothing happens, Can you please check what is supposed to happen (I think the user is prompted to fill the secure phrase, or ...)
If you confirm this dialog is related to the secure storage, we will have to hide it until the feature is enabled in Tchap
@giomfo giomfo added the iOS label Mar 28, 2022
@giomfo
Copy link
Contributor Author

giomfo commented Mar 29, 2022

Note: the Verify action is commented

@giomfo
Copy link
Contributor Author

giomfo commented Mar 29, 2022

I suggest using the existing SUPPORT_KEYS_BACKUP macro to hide the secure storage mechanism

phloux pushed a commit that referenced this issue Apr 1, 2022
Hide the session verification based on the secure storage (#486)
6112feb
@phloux phloux mentioned this issue Apr 1, 2022
Merged
phloux pushed a commit that referenced this issue Apr 4, 2022
Merge pull request #494 from tchapgouv/phlpro/486
7aaeb69 
Hide the session verification based on the secure storage (#486)
@phloux phloux mentioned this issue Apr 6, 2022
Merged
@giomfo giomfo closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@giomfo