Make minimumFractionDigits = maximumFractionDigits #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make minimumFractionDigits equal to maximumFractionDigits while roundingIncrement != 1 to sync with latest spec change in tc39/proposal-intl-numberformat-v3#85 which landed to spec text in Feb 22, 2022
sffc
approved these changes
Apr 23, 2022
| @@ -39,7 +39,8 @@ for (const [value, expected] of values) { | |||
| get roundingIncrement() { | |||
| callOrder.push("roundingIncrement"); | |||
| return value; | |||
| } | |||
| }, | |||
| minimumFractionDigits: 3 | |||
There was a problem hiding this comment.
Observation: This case, where maximumFractionDigits is not present and therefore defaults to 3, wasn't one that was considered when making the spec change. This is a little bit awkward, but I think it's fine, since in most cases roundingIncrement should have an explicit maximumFractionDigits value set (rather than relying on the implicit default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make minimumFractionDigits equal to maximumFractionDigits while
roundingIncrement != 1 to sync with latest spec change in
tc39/proposal-intl-numberformat-v3#85
which landed to spec text in Feb 22, 2022
@sffc @romulocintra