Update editorial according #81 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romulocintra
commented
Feb 4, 2022
| @@ -120,6 +120,7 @@ | |||
| 1. Let _roundingIncrement_ be ? GetNumberOption(_options_, *"roundingIncrement"*, 1, 5000, 1). | |||
| 1. If _roundingIncrement_ is not in « 1, 2, 5, 10, 20, 25, 50, 100, 200, 250, 500, 1000, 2000, 2500, 5000 », throw a *RangeError* exception. | |||
| 1. If _roundingIncrement_ is not 1 and _numberFormat_.[[RoundingType]] is not ~fractionDigits~, throw a *RangeError* exception. | |||
| 1. If _roundingIncrement_ and _numberFormat_.[[MaximumFractionDigits]] is not equal to _numberFormat_.[[MinimumFractionDigits]], throw a *RangeError* exception. | |||
| 1. Set _numberFormat_.[[RoundingIncrement]] to _roundingIncrement_. | |||
sffc
reviewed
Feb 16, 2022
numberformat/proposed.emu
Outdated
| @@ -120,6 +120,7 @@ | |||
| 1. Let _roundingIncrement_ be ? GetNumberOption(_options_, *"roundingIncrement"*, 1, 5000, 1). | |||
| 1. If _roundingIncrement_ is not in « 1, 2, 5, 10, 20, 25, 50, 100, 200, 250, 500, 1000, 2000, 2500, 5000 », throw a *RangeError* exception. | |||
| 1. If _roundingIncrement_ is not 1 and _numberFormat_.[[RoundingType]] is not ~fractionDigits~, throw a *RangeError* exception. | |||
| 1. If _roundingIncrement_ and _numberFormat_.[[MaximumFractionDigits]] is not equal to _numberFormat_.[[MinimumFractionDigits]], throw a *RangeError* exception. | |||
There was a problem hiding this comment.
_roundingIncrement_ is not a boolean; add is not 1
| @@ -120,6 +120,7 @@ | |||
| 1. Let _roundingIncrement_ be ? GetNumberOption(_options_, *"roundingIncrement"*, 1, 5000, 1). | |||
| 1. If _roundingIncrement_ is not in « 1, 2, 5, 10, 20, 25, 50, 100, 200, 250, 500, 1000, 2000, 2500, 5000 », throw a *RangeError* exception. | |||
| 1. If _roundingIncrement_ is not 1 and _numberFormat_.[[RoundingType]] is not ~fractionDigits~, throw a *RangeError* exception. | |||
| 1. If _roundingIncrement_ and _numberFormat_.[[MaximumFractionDigits]] is not equal to _numberFormat_.[[MinimumFractionDigits]], throw a *RangeError* exception. | |||
| 1. Set _numberFormat_.[[RoundingIncrement]] to _roundingIncrement_. | |||
There was a problem hiding this comment.
Please update diff.emu to keep them in sync
sffc
approved these changes
Feb 22, 2022
FrankYFTang
added a commit
to FrankYFTang/test262
that referenced
this pull request
Apr 20, 2022
Make minimumFractionDigits equal to maximumFractionDigits while roundingIncrement != 1 to sync with latest spec change in tc39/proposal-intl-numberformat-v3#85 which landed to spec text in Feb 22, 2022
|
@romulocintra please review tc39/test262#3494 |
rwaldron
pushed a commit
to tc39/test262
that referenced
this pull request
Apr 25, 2022
Make minimumFractionDigits equal to maximumFractionDigits while roundingIncrement != 1 to sync with latest spec change in tc39/proposal-intl-numberformat-v3#85 which landed to spec text in Feb 22, 2022
kangwoosukeq
pushed a commit
to prosyslab/v8
that referenced
this pull request
Apr 28, 2022
PR85 tc39/proposal-intl-numberformat-v3#85 Throw RangeError while roundingIncrement is not 1 and minimumFractionDigits != maximumFractionDigits Test by new test cases in intl/number-format/rounding-increment-v3.js Add more unit test to check the resolved options of roundingIncrement, minimumFractionDigits, and maximumFractionDigits. PR91 tc39/proposal-intl-numberformat-v3#91 Throw TypeError instead of RangeError while roundingIncrement is not 1 and RoundingType is not fractionDigits Test by intl402/NumberFormat/constructor-roundingIncrement-invalid.js in test262 Bug: v8:10776 Change-Id: I071bfe8b3e844c5999144d74bb5f79ea9811e37b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3603059 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80196}
catamorphism
pushed a commit
to nicolo-ribaudo/test262
that referenced
this pull request
May 30, 2022
Make minimumFractionDigits equal to maximumFractionDigits while roundingIncrement != 1 to sync with latest spec change in tc39/proposal-intl-numberformat-v3#85 which landed to spec text in Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81