-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Temporal.Duration.p*.with #3065
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
108 changes: 108 additions & 0 deletions
108
test/built-ins/Temporal/Duration/prototype/with/simple.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| // Copyright (C) 2021 the V8 project authors. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| /*--- | ||
| esid: sec-temporal.duration.prototype.with | ||
| description: Temporal.Duration.prototype.with will return correctly "merged" object. | ||
| info: | | ||
| 1. Let duration be the this value. | ||
| 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]). | ||
| 3. Let temporalDurationLike be ? ToPartialDuration(temporalDurationLike). | ||
| 4. If temporalDurationLike.[[Years]] is not undefined, then | ||
| a. Let years be temporalDurationLike.[[Years]]. | ||
| 5. Else, | ||
| a. Let years be duration.[[Years]]. | ||
| 6. If temporalDurationLike.[[Months]] is not undefined, then | ||
| a. Let months be temporalDurationLike.[[Months]]. | ||
| 7. Else, | ||
| a. Let months be duration.[[Months]]. | ||
| 8. If temporalDurationLike.[[Weeks]] is not undefined, then | ||
| a. Let weeks be temporalDurationLike.[[Weeks]]. | ||
| 9. Else, | ||
| a. Let weeks be duration.[[Weeks]]. | ||
| 10. If temporalDurationLike.[[Days]] is not undefined, then | ||
| a. Let days be temporalDurationLike.[[Days]]. | ||
| 11. Else, | ||
| a. Let days be duration.[[Days]]. | ||
| 12. If temporalDurationLike.[[Hours]] is not undefined, then | ||
| a. Let hours be temporalDurationLike.[[Hours]]. | ||
| 13. Else, | ||
| a. Let hours be duration.[[Hours]]. | ||
| 14. If temporalDurationLike.[[Minutes]] is not undefined, then | ||
| a. Let minutes be temporalDurationLike.[[Minutes]]. | ||
| 15. Else, | ||
| a. Let minutes be duration.[[Minutes]]. | ||
| 16. If temporalDurationLike.[[Seconds]] is not undefined, then | ||
| a. Let seconds be temporalDurationLike.[[Seconds]]. | ||
| 17. Else, | ||
| a. Let seconds be duration.[[Seconds]]. | ||
| 18. If temporalDurationLike.[[Milliseconds]] is not undefined, then | ||
| a. Let milliseconds be temporalDurationLike.[[Milliseconds]]. | ||
| 19. Else, | ||
| a. Let milliseconds be duration.[[Milliseconds]]. | ||
| 20. If temporalDurationLike.[[Microseconds]] is not undefined, then | ||
| a. Let microseconds be temporalDurationLike.[[Microseconds]]. | ||
| 21. Else, | ||
| a. Let microseconds be duration.[[Microseconds]]. | ||
| 22. If temporalDurationLike.[[Nanoseconds]] is not undefined, then | ||
| a. Let nanoseconds be temporalDurationLike.[[Nanoseconds]]. | ||
| 23. Else, | ||
| a. Let nanoseconds be duration.[[Nanoseconds]]. | ||
| 24. Return ? CreateTemporalDuration(years, months, weeks, days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds). | ||
| features: [Temporal] | ||
| ---*/ | ||
| function assertDuration(duration, years, months, weeks, days, hours, | ||
| minutes, seconds, milliseconds, microseconds, nanoseconds, sign, blank) { | ||
| assert.sameValue(years, duration.years, duration); | ||
| assert.sameValue(months, duration.months, duration); | ||
| assert.sameValue(weeks, duration.weeks, duration); | ||
| assert.sameValue(days, duration.days, duration); | ||
| assert.sameValue(hours, duration.hours, duration); | ||
| assert.sameValue(minutes, duration.minutes, duration); | ||
| assert.sameValue(seconds, duration.seconds, duration); | ||
| assert.sameValue(milliseconds, duration.milliseconds, duration); | ||
| assert.sameValue(microseconds, duration.microseconds, duration); | ||
| assert.sameValue(nanoseconds, duration.nanoseconds, duration); | ||
| assert.sameValue(sign, duration.sign, duration); | ||
| assert.sameValue(blank, duration.blank, duration); | ||
| } | ||
| let like1 = {years:9, months:8, weeks:7, days:6, hours: 5, minutes: 4, | ||
| seconds: 3, milliseconds: 2, microseconds: 1, nanoseconds: 10}; | ||
| let like2 = {years: 9, hours:5}; | ||
| let like3 = {months: 8, minutes:4}; | ||
| let like4 = {weeks: 7, seconds:3}; | ||
| let like5 = {days: 6, milliseconds:2}; | ||
| let like6 = {microseconds: 987, nanoseconds: 123}; | ||
| let like7 = {years:-9, months:-8, weeks:-7, days:-6, hours: -5, minutes: -4, | ||
| seconds: -3, milliseconds: -2, microseconds: -1, nanoseconds: -10}; | ||
|
|
||
| let d1 = new Temporal.Duration(); | ||
| assertDuration(d1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, true); | ||
| assertDuration(d1.with(like1), 9, 8, 7, 6, 5, 4, 3, 2, 1, 10, 1, false); | ||
| assertDuration(d1.with(like2), 9, 0, 0, 0, 5, 0, 0, 0, 0, 0, 1, false); | ||
| assertDuration(d1.with(like3), 0, 8, 0, 0, 0, 4, 0, 0, 0, 0, 1, false); | ||
| assertDuration(d1.with(like4), 0, 0, 7, 0, 0, 0, 3, 0, 0, 0, 1, false); | ||
| assertDuration(d1.with(like5), 0, 0, 0, 6, 0, 0, 0, 2, 0, 0, 1, false); | ||
| assertDuration(d1.with(like6), 0, 0, 0, 0, 0, 0, 0, 0, 987, 123, 1, false); | ||
| assertDuration(d1.with(like7), -9, -8, -7, -6, -5, -4, -3, -2, -1, -10, -1, | ||
| false); | ||
|
|
||
| let d2 = new Temporal.Duration(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); | ||
| assertDuration(d2, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 1, false); | ||
| assertDuration(d2.with(like1), 9, 8, 7, 6, 5, 4, 3, 2, 1, 10, 1, false); | ||
| assertDuration(d2.with(like7), -9, -8, -7, -6, -5, -4, -3, -2, -1, -10, -1, | ||
| false); | ||
|
|
||
| // Test large number | ||
| let d3 = new Temporal.Duration(1e5, 2e5, 3e5, 4e5, 5e5, 6e5, 7e5, 8e5, 9e5, | ||
| 10e5); | ||
| assertDuration(d3, 1e5, 2e5, 3e5, 4e5, 5e5, 6e5, 7e5, 8e5, 9e5, 10e5, 1, | ||
| false); | ||
| assertDuration(d3.with(like1), 9, 8, 7, 6, 5, 4, 3, 2, 1, 10, 1, false); | ||
| assertDuration(d3.with(like7), -9, -8, -7, -6, -5, -4, -3, -2, -1, -10, -1, | ||
| false); | ||
|
|
||
| // Test negative values | ||
| let d4 = new Temporal.Duration(-1, -2, -3, -4, -5, -6, -7, -8, -9, -10); | ||
| assertDuration(d4, -1, -2, -3, -4, -5, -6, -7, -8, -9, -10, -1, false); | ||
| assertDuration(d4.with(like1), 9, 8, 7, 6, 5, 4, 3, 2, 1, 10, 1, false); |
99 changes: 99 additions & 0 deletions
99
test/built-ins/Temporal/Duration/prototype/with/throw-range-error.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| // Copyright (C) 2021 the V8 project authors. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| /*--- | ||
| esid: sec-temporal.duration.prototype.with | ||
| description: Temporal.Duration.prototype.with will throw RangeError if the value is out of range. | ||
| info: | | ||
| 1. Let duration be the this value. | ||
| 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]). | ||
| 3. Let temporalDurationLike be ? ToPartialDuration(temporalDurationLike). | ||
| 4. If temporalDurationLike.[[Years]] is not undefined, then | ||
| a. Let years be temporalDurationLike.[[Years]]. | ||
| 5. Else, | ||
| a. Let years be duration.[[Years]]. | ||
| 6. If temporalDurationLike.[[Months]] is not undefined, then | ||
| a. Let months be temporalDurationLike.[[Months]]. | ||
| 7. Else, | ||
| a. Let months be duration.[[Months]]. | ||
| 8. If temporalDurationLike.[[Weeks]] is not undefined, then | ||
| a. Let weeks be temporalDurationLike.[[Weeks]]. | ||
| 9. Else, | ||
| a. Let weeks be duration.[[Weeks]]. | ||
| 10. If temporalDurationLike.[[Days]] is not undefined, then | ||
| a. Let days be temporalDurationLike.[[Days]]. | ||
| 11. Else, | ||
| a. Let days be duration.[[Days]]. | ||
| 12. If temporalDurationLike.[[Hours]] is not undefined, then | ||
| a. Let hours be temporalDurationLike.[[Hours]]. | ||
| 13. Else, | ||
| a. Let hours be duration.[[Hours]]. | ||
| 14. If temporalDurationLike.[[Minutes]] is not undefined, then | ||
| a. Let minutes be temporalDurationLike.[[Minutes]]. | ||
| 15. Else, | ||
| a. Let minutes be duration.[[Minutes]]. | ||
| 16. If temporalDurationLike.[[Seconds]] is not undefined, then | ||
| a. Let seconds be temporalDurationLike.[[Seconds]]. | ||
| 17. Else, | ||
| a. Let seconds be duration.[[Seconds]]. | ||
| 18. If temporalDurationLike.[[Milliseconds]] is not undefined, then | ||
| a. Let milliseconds be temporalDurationLike.[[Milliseconds]]. | ||
| 19. Else, | ||
| a. Let milliseconds be duration.[[Milliseconds]]. | ||
| 20. If temporalDurationLike.[[Microseconds]] is not undefined, then | ||
| a. Let microseconds be temporalDurationLike.[[Microseconds]]. | ||
| 21. Else, | ||
| a. Let microseconds be duration.[[Microseconds]]. | ||
| 22. If temporalDurationLike.[[Nanoseconds]] is not undefined, then | ||
| a. Let nanoseconds be temporalDurationLike.[[Nanoseconds]]. | ||
| 23. Else, | ||
| a. Let nanoseconds be duration.[[Nanoseconds]]. | ||
| 24. Return ? CreateTemporalDuration(years, months, weeks, days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds). | ||
| features: [Temporal] | ||
| ---*/ | ||
| let dPos = new Temporal.Duration(1, 2, 3, 4, 5, 6, 7, 8, 9, 10); | ||
| // Different sign | ||
| assert.throws(RangeError, ()=> dPos.with({years: -1}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dPos.with({months: -2}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dPos.with({weeks: -3}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dPos.with({days: -4}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dPos.with({hours: -5}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dPos.with({minutes: -6}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dPos.with({seconds: -7}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dPos.with({milliseconds: -8}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dPos.with({microseconds: -9}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dPos.with({nanoseconds: -10}), | ||
| "Invalid time value"); | ||
|
|
||
| // Test negative values | ||
| let dNeg = new Temporal.Duration(-1, -2, -3, -4, -5, -6, -7, -8, -9, -10); | ||
| // Throw when sign flip | ||
| assert.throws(RangeError, ()=> dNeg.with({years: 1}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dNeg.with({months: 2}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dNeg.with({weeks: 3}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dNeg.with({days: 4}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dNeg.with({hours: 5}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dNeg.with({minutes: 6}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dNeg.with({seconds: 7}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dNeg.with({milliseconds: 8}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dNeg.with({microseconds: 9}), | ||
| "Invalid time value"); | ||
| assert.throws(RangeError, ()=> dNeg.with({nanoseconds: 10}), | ||
| "Invalid time value"); | ||
76 changes: 76 additions & 0 deletions
76
test/built-ins/Temporal/Duration/prototype/with/throw-type-error.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // Copyright (C) 2021 the V8 project authors. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| /*--- | ||
| esid: sec-temporal.duration.prototype.with | ||
| description: Temporal.Duration.prototype.with will throw if the temporalDurationLike is object which contains values with key in singular form. | ||
| info: | | ||
| 1. Let duration be the this value. | ||
| 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]). | ||
| 3. Let temporalDurationLike be ? ToPartialDuration(temporalDurationLike). | ||
| 4. If temporalDurationLike.[[Years]] is not undefined, then | ||
| a. Let years be temporalDurationLike.[[Years]]. | ||
| 5. Else, | ||
| a. Let years be duration.[[Years]]. | ||
| 6. If temporalDurationLike.[[Months]] is not undefined, then | ||
| a. Let months be temporalDurationLike.[[Months]]. | ||
| 7. Else, | ||
| a. Let months be duration.[[Months]]. | ||
| 8. If temporalDurationLike.[[Weeks]] is not undefined, then | ||
| a. Let weeks be temporalDurationLike.[[Weeks]]. | ||
| 9. Else, | ||
| a. Let weeks be duration.[[Weeks]]. | ||
| 10. If temporalDurationLike.[[Days]] is not undefined, then | ||
| a. Let days be temporalDurationLike.[[Days]]. | ||
| 11. Else, | ||
| a. Let days be duration.[[Days]]. | ||
| 12. If temporalDurationLike.[[Hours]] is not undefined, then | ||
| a. Let hours be temporalDurationLike.[[Hours]]. | ||
| 13. Else, | ||
| a. Let hours be duration.[[Hours]]. | ||
| 14. If temporalDurationLike.[[Minutes]] is not undefined, then | ||
| a. Let minutes be temporalDurationLike.[[Minutes]]. | ||
| 15. Else, | ||
| a. Let minutes be duration.[[Minutes]]. | ||
| 16. If temporalDurationLike.[[Seconds]] is not undefined, then | ||
| a. Let seconds be temporalDurationLike.[[Seconds]]. | ||
| 17. Else, | ||
| a. Let seconds be duration.[[Seconds]]. | ||
| 18. If temporalDurationLike.[[Milliseconds]] is not undefined, then | ||
| a. Let milliseconds be temporalDurationLike.[[Milliseconds]]. | ||
| 19. Else, | ||
| a. Let milliseconds be duration.[[Milliseconds]]. | ||
| 20. If temporalDurationLike.[[Microseconds]] is not undefined, then | ||
| a. Let microseconds be temporalDurationLike.[[Microseconds]]. | ||
| 21. Else, | ||
| a. Let microseconds be duration.[[Microseconds]]. | ||
| 22. If temporalDurationLike.[[Nanoseconds]] is not undefined, then | ||
| a. Let nanoseconds be temporalDurationLike.[[Nanoseconds]]. | ||
| 23. Else, | ||
| a. Let nanoseconds be duration.[[Nanoseconds]]. | ||
| 24. Return ? CreateTemporalDuration(years, months, weeks, days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds). | ||
| features: [Temporal] | ||
| ---*/ | ||
|
|
||
| let d1 = new Temporal.Duration(); | ||
| // singular throw | ||
| assert.throws(TypeError, () => d1.with({year:1}), | ||
| "invalid_argument"); | ||
| assert.throws(TypeError, () => d1.with({month:1}), | ||
| "invalid_argument"); | ||
| assert.throws(TypeError, () => d1.with({week:1}), | ||
| "invalid_argument"); | ||
| assert.throws(TypeError, () => d1.with({day:1}), | ||
| "invalid_argument"); | ||
| assert.throws(TypeError, () => d1.with({hour:1}), | ||
| "invalid_argument"); | ||
| assert.throws(TypeError, () => d1.with({minute:1}), | ||
| "invalid_argument"); | ||
| assert.throws(TypeError, () => d1.with({second:1}), | ||
| "invalid_argument"); | ||
| assert.throws(TypeError, () => d1.with({millisecond:1}), | ||
| "invalid_argument"); | ||
| assert.throws(TypeError, () => d1.with({microsecond:1}), | ||
| "invalid_argument"); | ||
| assert.throws(TypeError, () => d1.with({nanosecond:1}), | ||
| "invalid_argument"); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could probably have a description like "Years argument opposite sign from receiver"