Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Temporal.Duration.p*.with #3065

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions test/built-ins/Temporal/Duration/prototype/with/all-negative.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-temporal.duration.prototype.with
description: Temporal.Duration.prototype.with will return correctly "merged" object
with all negative values.
info: |
1. Let duration be the this value.
2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
3. Let temporalDurationLike be ? ToPartialDuration(temporalDurationLike).
4. If temporalDurationLike.[[Years]] is not undefined, then
a. Let years be temporalDurationLike.[[Years]].
5. Else,
a. Let years be duration.[[Years]].
6. If temporalDurationLike.[[Months]] is not undefined, then
a. Let months be temporalDurationLike.[[Months]].
7. Else,
a. Let months be duration.[[Months]].
8. If temporalDurationLike.[[Weeks]] is not undefined, then
a. Let weeks be temporalDurationLike.[[Weeks]].
9. Else,
a. Let weeks be duration.[[Weeks]].
10. If temporalDurationLike.[[Days]] is not undefined, then
a. Let days be temporalDurationLike.[[Days]].
11. Else,
a. Let days be duration.[[Days]].
12. If temporalDurationLike.[[Hours]] is not undefined, then
a. Let hours be temporalDurationLike.[[Hours]].
13. Else,
a. Let hours be duration.[[Hours]].
14. If temporalDurationLike.[[Minutes]] is not undefined, then
a. Let minutes be temporalDurationLike.[[Minutes]].
15. Else,
a. Let minutes be duration.[[Minutes]].
16. If temporalDurationLike.[[Seconds]] is not undefined, then
a. Let seconds be temporalDurationLike.[[Seconds]].
17. Else,
a. Let seconds be duration.[[Seconds]].
18. If temporalDurationLike.[[Milliseconds]] is not undefined, then
a. Let milliseconds be temporalDurationLike.[[Milliseconds]].
19. Else,
a. Let milliseconds be duration.[[Milliseconds]].
20. If temporalDurationLike.[[Microseconds]] is not undefined, then
a. Let microseconds be temporalDurationLike.[[Microseconds]].
21. Else,
a. Let microseconds be duration.[[Microseconds]].
22. If temporalDurationLike.[[Nanoseconds]] is not undefined, then
a. Let nanoseconds be temporalDurationLike.[[Nanoseconds]].
23. Else,
a. Let nanoseconds be duration.[[Nanoseconds]].
24. Return ? CreateTemporalDuration(years, months, weeks, days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds).
features: [Temporal]
includes: [temporalHelpers.js]
---*/
let like7 = {years:-9, months:-8, weeks:-7, days:-6, hours: -5, minutes: -4,
seconds: -3, milliseconds: -2, microseconds: -1, nanoseconds: -10};

let d1 = new Temporal.Duration();
TemporalHelpers.assertDuration(
d1.with(like7), -9, -8, -7, -6, -5, -4, -3, -2, -1, -10, "replace all neg");

let d2 = new Temporal.Duration(1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
TemporalHelpers.assertDuration(
d2.with(like7), -9, -8, -7, -6, -5, -4, -3, -2, -1, -10, "replace all negative");

// Test large number
let d3 = new Temporal.Duration(1e5, 2e5, 3e5, 4e5, 5e5, 6e5, 7e5, 8e5, 9e5,
10e5);
TemporalHelpers.assertDuration(
d3.with(like7), -9, -8, -7, -6, -5, -4, -3, -2, -1, -10, "all negative");
76 changes: 76 additions & 0 deletions test/built-ins/Temporal/Duration/prototype/with/all-positive.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-temporal.duration.prototype.with
description: Temporal.Duration.prototype.with will return correctly "merged" object
with all positive duration.
info: |
1. Let duration be the this value.
2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
3. Let temporalDurationLike be ? ToPartialDuration(temporalDurationLike).
4. If temporalDurationLike.[[Years]] is not undefined, then
a. Let years be temporalDurationLike.[[Years]].
5. Else,
a. Let years be duration.[[Years]].
6. If temporalDurationLike.[[Months]] is not undefined, then
a. Let months be temporalDurationLike.[[Months]].
7. Else,
a. Let months be duration.[[Months]].
8. If temporalDurationLike.[[Weeks]] is not undefined, then
a. Let weeks be temporalDurationLike.[[Weeks]].
9. Else,
a. Let weeks be duration.[[Weeks]].
10. If temporalDurationLike.[[Days]] is not undefined, then
a. Let days be temporalDurationLike.[[Days]].
11. Else,
a. Let days be duration.[[Days]].
12. If temporalDurationLike.[[Hours]] is not undefined, then
a. Let hours be temporalDurationLike.[[Hours]].
13. Else,
a. Let hours be duration.[[Hours]].
14. If temporalDurationLike.[[Minutes]] is not undefined, then
a. Let minutes be temporalDurationLike.[[Minutes]].
15. Else,
a. Let minutes be duration.[[Minutes]].
16. If temporalDurationLike.[[Seconds]] is not undefined, then
a. Let seconds be temporalDurationLike.[[Seconds]].
17. Else,
a. Let seconds be duration.[[Seconds]].
18. If temporalDurationLike.[[Milliseconds]] is not undefined, then
a. Let milliseconds be temporalDurationLike.[[Milliseconds]].
19. Else,
a. Let milliseconds be duration.[[Milliseconds]].
20. If temporalDurationLike.[[Microseconds]] is not undefined, then
a. Let microseconds be temporalDurationLike.[[Microseconds]].
21. Else,
a. Let microseconds be duration.[[Microseconds]].
22. If temporalDurationLike.[[Nanoseconds]] is not undefined, then
a. Let nanoseconds be temporalDurationLike.[[Nanoseconds]].
23. Else,
a. Let nanoseconds be duration.[[Nanoseconds]].
24. Return ? CreateTemporalDuration(years, months, weeks, days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds).
features: [Temporal]
includes: [temporalHelpers.js]
---*/
let like1 = {years:9, months:8, weeks:7, days:6, hours: 5, minutes: 4,
seconds: 3, milliseconds: 2, microseconds: 1, nanoseconds: 10};

let d1 = new Temporal.Duration();
TemporalHelpers.assertDuration(
d1.with(like1), 9, 8, 7, 6, 5, 4, 3, 2, 1, 10, "replace all positive");

let d2 = new Temporal.Duration(1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
TemporalHelpers.assertDuration(
d2.with(like1), 9, 8, 7, 6, 5, 4, 3, 2, 1, 10, "replace all positive");

// Test large number
let d3 = new Temporal.Duration(1e5, 2e5, 3e5, 4e5, 5e5, 6e5, 7e5, 8e5, 9e5,
10e5);
TemporalHelpers.assertDuration(
d3.with(like1), 9, 8, 7, 6, 5, 4, 3, 2, 1, 10, "all positive");

// Test negative values
let d4 = new Temporal.Duration(-1, -2, -3, -4, -5, -6, -7, -8, -9, -10);
TemporalHelpers.assertDuration(
d4.with(like1), 9, 8, 7, 6, 5, 4, 3, 2, 1, 10, "replace all neg to all positive");
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-temporal.duration.prototype.with
description: Temporal.Duration.prototype.with will return correctly "merged" object
with partial positive values.
info: |
1. Let duration be the this value.
2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
3. Let temporalDurationLike be ? ToPartialDuration(temporalDurationLike).
4. If temporalDurationLike.[[Years]] is not undefined, then
a. Let years be temporalDurationLike.[[Years]].
5. Else,
a. Let years be duration.[[Years]].
6. If temporalDurationLike.[[Months]] is not undefined, then
a. Let months be temporalDurationLike.[[Months]].
7. Else,
a. Let months be duration.[[Months]].
8. If temporalDurationLike.[[Weeks]] is not undefined, then
a. Let weeks be temporalDurationLike.[[Weeks]].
9. Else,
a. Let weeks be duration.[[Weeks]].
10. If temporalDurationLike.[[Days]] is not undefined, then
a. Let days be temporalDurationLike.[[Days]].
11. Else,
a. Let days be duration.[[Days]].
12. If temporalDurationLike.[[Hours]] is not undefined, then
a. Let hours be temporalDurationLike.[[Hours]].
13. Else,
a. Let hours be duration.[[Hours]].
14. If temporalDurationLike.[[Minutes]] is not undefined, then
a. Let minutes be temporalDurationLike.[[Minutes]].
15. Else,
a. Let minutes be duration.[[Minutes]].
16. If temporalDurationLike.[[Seconds]] is not undefined, then
a. Let seconds be temporalDurationLike.[[Seconds]].
17. Else,
a. Let seconds be duration.[[Seconds]].
18. If temporalDurationLike.[[Milliseconds]] is not undefined, then
a. Let milliseconds be temporalDurationLike.[[Milliseconds]].
19. Else,
a. Let milliseconds be duration.[[Milliseconds]].
20. If temporalDurationLike.[[Microseconds]] is not undefined, then
a. Let microseconds be temporalDurationLike.[[Microseconds]].
21. Else,
a. Let microseconds be duration.[[Microseconds]].
22. If temporalDurationLike.[[Nanoseconds]] is not undefined, then
a. Let nanoseconds be temporalDurationLike.[[Nanoseconds]].
23. Else,
a. Let nanoseconds be duration.[[Nanoseconds]].
24. Return ? CreateTemporalDuration(years, months, weeks, days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds).
features: [Temporal]
includes: [temporalHelpers.js]
---*/
let like2 = {years: 9, hours:5};
let like3 = {months: 8, minutes:4};
let like4 = {weeks: 7, seconds:3};
let like5 = {days: 6, milliseconds:2};
let like6 = {microseconds: 987, nanoseconds: 123};

let d1 = new Temporal.Duration();
TemporalHelpers.assertDuration(
d1.with(like2), 9, 0, 0, 0, 5, 0, 0, 0, 0, 0, "repalce years and hours");
TemporalHelpers.assertDuration(
d1.with(like3), 0, 8, 0, 0, 0, 4, 0, 0, 0, 0, "replace months and minutes");
TemporalHelpers.assertDuration(
d1.with(like4), 0, 0, 7, 0, 0, 0, 3, 0, 0, 0, "replace weeks and seconds");
TemporalHelpers.assertDuration(
d1.with(like5), 0, 0, 0, 6, 0, 0, 0, 2, 0, 0, "replace days and milliseconds");
TemporalHelpers.assertDuration(
d1.with(like6), 0, 0, 0, 0, 0, 0, 0, 0, 987, 123, "replace mis and ns");

let d2 = new Temporal.Duration(1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
TemporalHelpers.assertDuration(
d2.with(like2), 9, 2, 3, 4, 5, 6, 7, 8, 9, 10, "replace years and hours");
TemporalHelpers.assertDuration(
d2.with(like3), 1, 8, 3, 4, 5, 4, 7, 8, 9, 10, "replace months and minutes");
TemporalHelpers.assertDuration(
d2.with(like4), 1, 2, 7, 4, 5, 6, 3, 8, 9, 10, "replace weeks and seconds");
TemporalHelpers.assertDuration(
d2.with(like5), 1, 2, 3, 6, 5, 6, 7, 2, 9, 10, "replace days and ns");
TemporalHelpers.assertDuration(
d2.with(like6), 1, 2, 3, 4, 5, 6, 7, 8, 987, 123, "replace mis and ns");
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-temporal.duration.prototype.with
description: Temporal.Duration.prototype.with throws RangeError on
CreateTemporalDuration if resulting duration is invalid.
info: |
24. Return ? CreateTemporalDuration(years, months, weeks, days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds).
features: [Temporal]
---*/
let dur = new Temporal.Duration(1,2,3,4,5,6,7,8,9,10);
[
{years: -1}, {months: -1}, {weeks: -1}, {days: -1},
{hours: -1}, {minutes: -1}, {seconds: -1}, {milliseconds: -1},
{microseconds: -1}, {nanoseconds: -1},
].forEach(
function(durationLike) {
assert.throws(RangeError, () => dur.with(durationLike),
"Throw RangeError if content in temporalDurationLike conflict with duration" +
JSON.stringify(durationLike));
});

dur = new Temporal.Duration(-1,-2,-3,-4,-5,-6,-7,-8,-9,-10);
[
{years: 1}, {months: 1}, {weeks: 1}, {days: 1},
{hours: 1}, {minutes: 1}, {seconds: 1}, {milliseconds: 1},
{microseconds: 1}, {nanoseconds: 1},
].forEach(
function(durationLike) {
assert.throws(RangeError, () => dur.with(durationLike),
"Throw RangeError if content in temporalDurationLike conflict with duration" +
JSON.stringify(durationLike));
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-temporal.duration.prototype.with
description: Temporal.Duration.prototype.with throws TypeError on
RequireInternalSlot if object has no internal slot.
info: |
2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
features: [Temporal]
---*/
let dur = new Temporal.Duration(1,2,3,4,5);

let badDur = { with: dur.with }
assert.throws(TypeError, () => badDur.with({years: 3}),
"Throw TypeError if there are no internal slot");
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-temporal.duration.prototype.with
description: Temporal.Duration.prototype.with throws TypeError on
ToPartialDuration if temporalDurationLike is not valid object.
info: |
2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
features: [Temporal]
---*/
let dur = new Temporal.Duration(1,2,3,4,5);

["string", {}, true, false, NaN, Infinity, undefined, NaN,
123, Symbol(), 456n, [],
// object with only singular key
{year: 1}, {month: 2}, {week: 3}, {day: 4},
{hour: 5}, {minute: 6}, {second: 7}, {millisecond: 8},
{microsecond: 9}, {nanosecond: 10}
].forEach(
function(durationLike) {
assert.throws(TypeError, () => dur.with(durationLike),
"Throw TypeError if temporalDurationLike is not valid");
});