Move test262 tests upstream #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are being moved to tc39/test262.
159ad10 to
da870e1
Compare
Codecov Report
@@ Coverage Diff @@
## main #1853 +/- ##
==========================================
+ Coverage 94.76% 94.78% +0.01%
==========================================
Files 19 19
Lines 10969 10969
Branches 1712 1712
==========================================
+ Hits 10395 10397 +2
+ Misses 559 557 -2
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Marked as draft, because I will need to update the submodule when the test262 pull request is merged. |
ptomato
added a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Sep 29, 2021
The Temporal test262 tests are being removed from tc39/proposal-temporal (see tc39/proposal-temporal#1853 ) and moved to tc39/test262 where they will continue to be developed. Run them from a git submodule so we can pull in new upstream versions when we are ready for them. Instead of cloning tc39/proposal-temporal to run the tests, we copy the relevant parts of its test262 CI script. The files expected-failures.txt, parseResults.js, and preprocessor.test262.cjs are copied from there as well.
Instead of an in-tree checkout use a git submodule of test262 so we can pin the tests to a particular commit and pull in updates when we are ready for them. Requires some changes in various paths. The tests that were currently marked as expected to fail were not added to upstream test262 yet, so they are removed from expected-failures.txt.
|
The tests now live in tc39/test262, so this is ready for review. |
ptomato
added a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Oct 1, 2021
The Temporal test262 tests are being removed from tc39/proposal-temporal (see tc39/proposal-temporal#1853 ) and moved to tc39/test262 where they will continue to be developed. Run them from a git submodule so we can pull in new upstream versions when we are ready for them. Instead of cloning tc39/proposal-temporal to run the tests, we copy the relevant parts of its test262 CI script. The files expected-failures.txt, parseResults.js, and preprocessor.test262.cjs are copied from there as well.
ptomato
added a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Oct 1, 2021
The Temporal test262 tests are being removed from tc39/proposal-temporal (see tc39/proposal-temporal#1853 ) and moved to tc39/test262 where they will continue to be developed. Run them from a git submodule so we can pull in new upstream versions when we are ready for them. Instead of cloning tc39/proposal-temporal to run the tests, we copy the relevant parts of its test262 CI script. The files expected-failures.txt, parseResults.js, and preprocessor.test262.cjs are copied from there as well.
Ms2ger
approved these changes
Oct 4, 2021
ptomato
added a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Oct 5, 2021
The Temporal test262 tests are being removed from tc39/proposal-temporal (see tc39/proposal-temporal#1853 ) and moved to tc39/test262 where they will continue to be developed. Run them from a git submodule so we can pull in new upstream versions when we are ready for them. Instead of cloning tc39/proposal-temporal to run the tests, we copy the relevant parts of its test262 CI script. The files expected-failures.txt, parseResults.js, and preprocessor.test262.cjs are copied from there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in tc39/test262#3002, this moves the test262 tests upstream, where they will continue to be developed. Includes changes to our package.json and CI setup to run the test262 tests using a git submodule, instead of an in-tree checkout, so that we can pull in updates from test262 when we are ready for them.