Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the upstream test262 tests #61

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Run the upstream test262 tests #61

merged 1 commit into from
Oct 5, 2021

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Sep 29, 2021

The Temporal test262 tests are being removed from tc39/proposal-temporal
(see tc39/proposal-temporal#1853 ) and moved
to tc39/test262 where they will continue to be developed. Run them from a
git submodule so we can pull in new upstream versions when we are ready
for them.

Instead of cloning tc39/proposal-temporal to run the tests, we copy the
relevant parts of its test262 CI script. The files expected-failures.txt,
parseResults.js, and preprocessor.test262.cjs are copied from there as
well.

@ptomato ptomato marked this pull request as draft September 29, 2021 23:00
@ptomato
Copy link
Contributor Author

ptomato commented Sep 29, 2021

This is marked as draft for the time being - the submodule is pinned to the temporal-tests branch of ptomato/test262 and should be updated when tc39/test262#3223 is merged.

The Temporal test262 tests are being removed from tc39/proposal-temporal
(see tc39/proposal-temporal#1853 ) and moved
to tc39/test262 where they will continue to be developed. Run them from a
git submodule so we can pull in new upstream versions when we are ready
for them.

Instead of cloning tc39/proposal-temporal to run the tests, we copy the
relevant parts of its test262 CI script. The files expected-failures.txt,
parseResults.js, and preprocessor.test262.cjs are copied from there as
well.
@ptomato ptomato marked this pull request as ready for review October 1, 2021 19:06
@ptomato
Copy link
Contributor Author

ptomato commented Oct 1, 2021

The test262 tests have been moved to tc39/test262, so this is ready for review now.

@12wrigja
Copy link
Contributor

12wrigja commented Oct 5, 2021

@ptomato Is this ready to merge? It looks like the existing setup is now broken for this repo.

@ptomato ptomato merged commit ff93778 into main Oct 5, 2021
@ptomato
Copy link
Contributor Author

ptomato commented Oct 5, 2021

I had missed the r+, sorry!

@ptomato ptomato deleted the test262-upstream branch October 5, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants