This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Align with the base spec in caching "next" methods #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @kmiller68 @caitp |
Jamesernator
reviewed
Dec 6, 2017
spec/iterator-operations.html
Outdated
| 1. <ins>Set _method_ to ? GetMethod(_obj_, @@asyncIterator).</ins> | ||
| 1. <ins>If _method_ is *undefined*, | ||
| 1. <ins>Let _syncMethod_ be ? GetMethod(_obj_, @@iterator).</ins> | ||
| 1. <ins>Let _syncIteratorRecord_ be ? GetIterator(_obj_, ~normal~, _method_).</ins> |
There was a problem hiding this comment.
Should this be GetIterator(_obj_, ~normal~, _syncMethod_) not simply the method which we already know to be undefined?
There was a problem hiding this comment.
Yep, good catch, thanks!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116. See tc39/ecma262#1021.
I think I got everything, but I'd certainly appreciate review from anyone available who wants to make sure I didn't miss anything. /cc @Jamesernator who opened #116.