Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

getIterator can return an AsyncFromSyncIterator instead of a record #120

Closed
Jamesernator opened this issue Dec 12, 2017 · 0 comments
Closed

Comments

@Jamesernator
Copy link

Something I didn't notice before when looking over the pull request #119 is that getIterator can return either an iterator record or an AsyncFromSyncIterator. Instead of returning CreateAsyncFromSyncIterator(syncIteratorRecord) we want an actual iterator record for that.

A simple change should just be to replace:

return ? CreateAsyncFromSyncIterator(syncIteratorRecord)

with:

let asyncFromSyncIterator be ? CreateAsyncFromSyncIterator(syncIteratorRecord)
return getIterator(asyncFromSyncIterator, "async")
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant