Release jul19 #962
Release jul19 #962
Conversation
Add method next, which was removed when the code was addapted to python3. 'next' is needed, as it is used in other code parts, including other related projects as taurus-pyqtgraph.
Add method next
The jdraw_view main raises a relative import error. Fix it, using absolute imports instead.
Adapt QGraphicsTextBoxing and TaurusGraphicsAttributeItem classes to be compatible with py2/py3.
Avoid relative import error in jdraw module
This line was commented by mistake. Uncomment it.
QGraphicsItem.scale(sx, sy) is obsolete even in Qt4. Replace it for equivalent code.
From the copy module docs (https://docs.python.org/3/library/copy.html) : > If the __deepcopy__() implementation needs to make a deep copy of a > component, it should call the deepcopy() function with the component > as first argument and the memo dictionary as second argument.
Add the Python version to the info logged when loading the external.qt module.
Various implementations of dropMimeData in Taurus do casts of QBytesArray to str which may be dangerous in py3. Use bytes and decode instead.
- use QtGui.QTransform from Qt - avoid redundant assigning of variable
Adapt TaurusGraphicsAttributeItem to be compatible with python3
Failiures to load plugins for taurus.qt.qtgui entry-points are only logged with debug level and therefore they may be missed. Increase log level for failures to warning and for success to info.
Some signals use `object` in their signatures, but this may be problematic when object is imported from builtins (futurize module). To avoid it, 'PyQt_PyObject' (or 'PyObject' for PySide/PySide2) should be used instead. Wrap these two options in a variable `PY_OBJECT` of `taurus.external.qt.compat` and replace 'object' by PY_OBJECT in all signal signatures of Taurus
Change log level in taurus.qt.qtgui entry point loading
Use PY_OBJECT for signal signatures
The getValidatorFromName method returns the validator object corresponding to the given model name.
Add a helper to get a TaurusModel name validator object for the giving model name.
Add python version to PyQt info log
(doc) Add note in the taurus coding conventions about Qt imports
Change TaurusModelSelectorItem.modelsAdded and TaurusModelSelector.modelsAdded signals signature from 'QStringList' to list. It will allow to pass XY models.
The TaurusTrend2d does not provide a GUI access to save/restore settings This feature can only be tested programmatically for now, so remove it from the check list.
The ini is platform dependent and it was created with py2 and qt4. Furthermore, it is not used at all.
The signature of PerspectiveToolBar.perspectiveChanged signal is 'str', but it is used also with an integer enumeration as argument, causing an exception (e.g. when switching perspective to "server" in the "Table Panels" demo). Fix it by changing the signature to compat.PY_OBJECT .
|
I've updated this release PR to bring fixes for:
|
Relative imports are failing when launching taurus designer since a subprocess is used. Convert to absolute imports. Closes taurus-org#968
TaurusValue uses qtgui.qwt5.TaurusArrayEditor as the default writeWidget for numerical 1D attributes. This is fails if qwt5 is not available. Fix by using it only if Qwt5 can be imported (py2qt4). Closes taurus-org#973
|
Hi all, |
That would be nice! |
|
Hi, Just to let you know that I have done all the manual tests for CentOS7 and py2qt4, and I've found a few issues reported in #980. Cheers, |
|
I've just closed all the test issues (#959, #965, #977, #974, #983). Some issues have been identified, but none are considered release-critical. IMHO, the release can go on, so I bumped the version from 4.6.0a --> 4.6.0 and updated the CHANGELOG with today's as the date of the release. If the other @taurus-org/integrators are fine with it, please approve your pending reviews |
There was a problem hiding this comment.
For me it looks good! We also used the 4.5.5a which is very similar to this release (4.6) while testing Sardana Python 3 sardana-org/sardana#1175 and Taurus worked correctly. For me go ahead with the release! Many thanks to the release team!
|
Hi, Although the issues reported are important for MAX IV, I don't consider them as an impediment to continue with the release, and they can be fixed after finishing it. Cheers. |
The code is unchanged since 2019-07-31, but the release PR was not merged until today.
|
I updated the release date in the CHANGELOG, and I am merging. Thanks to all the contributors of this release, and specially to those who worked on the manual tests. |
This is a PR to master for the official Jul19 release. Final tests (automatic and manual) should be done based on it before accepting the merge.
So, this is a call for help from @taurus-org/integrators and any other person willing to help to test this branch ASAP in their respective systems.
For the moment the following tests are planned:
(please let us know in the comments of this PR if you plan to do some more manual tests)
Notes: