This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Adapt TaurusGraphicsAttributeItem to be compatible with python3 #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt QGraphicsTextBoxing and TaurusGraphicsAttributeItem classes to be compatible with py2/py3.
cpascual
reviewed
Mar 13, 2019
| self._text = Qt.QGraphicsTextItem(self) | ||
| if scene is not None: | ||
| scene.addItem(self._text) | ||
| # self._text.scale(self._TEXT_RATIO, self._TEXT_RATIO) |
There was a problem hiding this comment.
This line is now commented... can it really be safely ignored?
There was a problem hiding this comment.
It was commented by mistake
There was a problem hiding this comment.
Sorry, it must be changed since it fails with py3
cpascual
reviewed
Mar 13, 2019
This line was commented by mistake. Uncomment it.
QGraphicsItem.scale(sx, sy) is obsolete even in Qt4. Replace it for equivalent code.
- use QtGui.QTransform from Qt - avoid redundant assigning of variable
|
I've checked with: python -m taurus.qt.qtgui.graphic.jdraw.jdraw_view ~/src/taurus/lib/taurus/qt/qtgui/graphic/jdraw/test/res/SimpleScalarViewer.jdwWith the develop version, this works only for py2+qt4 but it fails for py3+qt4, py3+qt5, py2+qt5 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt QGraphicsTextBoxing and TaurusGraphicsAttributeItem classes
to be compatible with py2/py3.