-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose eval
method
#289
Conversation
The problem is this method is not thread-safe. It should be called on the main thread only. |
Yes, calling |
Yeah, I think we could do that. If @lucasfernog also agrees (since tauri will need some custom event on EventLoopProxy), let's remove the dispatcher and all its related methods and expose this instead. |
FYI, |
Closed in favor of #291. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This allows executing javascript code without having to use the
mpsc::channel
and helps to simplifyhandle_event_loop
intauri-runtime-wry
(see tauri-apps/tauri#1962).