Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update wry, simplify script eval #1965

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Conversation

geieredgar
Copy link
Contributor

@geieredgar geieredgar commented Jun 7, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Requires that a new version of wry containing tauri-apps/wry#289 tauri-apps/wry#291 is released.

@lucasfernog lucasfernog marked this pull request as ready for review June 16, 2021 00:39
@lucasfernog lucasfernog requested a review from a team as a code owner June 16, 2021 00:39
@lucasfernog lucasfernog requested a review from a team June 16, 2021 00:39
@lucasfernog lucasfernog changed the title refactor: simplify handle_event_loop refactor: update wry, simplify script eval Jun 16, 2021
@lucasfernog lucasfernog merged commit cca8115 into tauri-apps:dev Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants